Page MenuHomePhabricator

Fix some race condition in ConstString around Mangled name handling
ClosedPublic

Authored by tberghammer on Oct 21 2015, 6:38 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Fix some race condition in ConstString around Mangled name handling.
tberghammer updated this object.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
clayborg accepted this revision.Oct 21 2015, 9:48 AM
clayborg edited edge metadata.

Looks fine. Might want to make "h" const in places noted by inlined comments, but other than that it looks good.

source/Core/ConstString.cpp
39 ↗(On Diff #38006)

const uint8_t h?

52 ↗(On Diff #38006)

const uint8_t h?

65 ↗(On Diff #38006)

const uint8_t h?

70 ↗(On Diff #38006)

const uint8_t h?

139 ↗(On Diff #38006)

const uint8_t h?

This revision is now accepted and ready to land.Oct 21 2015, 9:48 AM
This revision was automatically updated to reflect the committed changes.
tberghammer marked 5 inline comments as done.