This is an archive of the discontinued LLVM Phabricator instance.

A doccomment for CombineTo, and some NFC refactorings
ClosedPublic

Authored by tyomitch on Oct 14 2015, 7:05 AM.

Details

Summary

Caching SDLoc(N), instead of recreating it in every single
function call, keeps the code denser, and allows to unwrap long lines.

Diff Detail

Event Timeline

tyomitch updated this revision to Diff 37350.Oct 14 2015, 7:05 AM
tyomitch retitled this revision from to A doccomment for CombineTo, and some NFC refactorings.
tyomitch updated this object.
tyomitch added reviewers: sunfish, atrick, sdmitrouk.
tyomitch added a subscriber: llvm-commits.
jmolloy added inline comments.
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
159

Why doccomment this one but not any of the others?

tyomitch updated this revision to Diff 37360.Oct 14 2015, 9:14 AM

Patch updated

This revision was automatically updated to reflect the committed changes.