This is an archive of the discontinued LLVM Phabricator instance.

Differential D13719

Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
ClosedPublic

Authored by abidh on Oct 14 2015, 2:55 AM.

Details

Reviewers
zturner
clayborg
Commits
rG3eedf96a5a45: Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
rLLDB250380: Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
rL250380: Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
Summary

I see a lot of following warnings in LLDBWrapPython.cpp while building with gcc 4.9 on Linux.
"warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers [-Wcast-qual]"

Is it ok to add -Wno-cast-qual for this file in cmake for gcc. This option seems to be already present
for autotool case.

Diff Detail

Event Timeline

abidh updated this revision to Diff 37325.Oct 14 2015, 2:55 AM
abidh retitled this revision from to Fix warnings in LLDBWrapPython.cpp with gcc 4.9..
abidh updated this object.
abidh added reviewers: zturner, clayborg.
abidh added a subscriber: lldb-commits.
clayborg accepted this revision.Oct 14 2015, 10:02 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Oct 14 2015, 10:02 AM
abidh closed this revision.Oct 15 2015, 1:28 AM

Revision Contents

PathSize
cmake/
2 lines

Diff 37325

cmake/LLDBDependencies.cmake

Show First 20 Lines • Show All 185 Lines • ▼ Show 20 Linesif ( NOT LLDB_DISABLE_PYTHON )
set_source_files_properties(${LLDB_WRAP_PYTHON} PROPERTIES GENERATED 1) set_source_files_properties(${LLDB_WRAP_PYTHON} PROPERTIES GENERATED 1)
if (CLANG_CL) if (CLANG_CL)
set_source_files_properties(${LLDB_WRAP_PYTHON} PROPERTIES COMPILE_FLAGS -Wno-unused-function) set_source_files_properties(${LLDB_WRAP_PYTHON} PROPERTIES COMPILE_FLAGS -Wno-unused-function)
endif() endif()
if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND
NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin") NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
set_property(SOURCE ${LLDB_WRAP_PYTHON} set_property(SOURCE ${LLDB_WRAP_PYTHON}
APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-sequence-point") APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-sequence-point -Wno-cast-qual")
endif () endif ()
endif() endif()