This is an archive of the discontinued LLVM Phabricator instance.

Differential D13690

Silence MSVC warning D9025 when /W3 present after /W4
AbandonedPublic

Authored by angelsl on Oct 13 2015, 4:16 AM.

Details

Reviewers
compnerd

Diff Detail

Event Timeline

angelsl updated this revision to Diff 37229.Oct 13 2015, 4:16 AM
angelsl retitled this revision from to Silence MSVC warning D9025 when /W3 present after /W4.
angelsl updated this object.
angelsl added a reviewer: compnerd.
angelsl added subscribers: compnerd, llvm-commits.
compnerd added inline comments.Oct 14 2015, 7:29 PM
CMakeLists.txt
208

What happens if COMPILER_RT_HAS_W3_FLAG is set to false? In this case, you've cleared out the flag but not re-appended it. Or can that not occur?

angelsl updated this revision to Diff 37454.Oct 15 2015, 1:50 AM
angelsl marked an inline comment as done.
compnerd edited edge metadata.Oct 18 2015, 6:27 PM

This would avoid that issue at the cost of preventing the user from specifying an alternative flag via the command line. Is there a good reason to disallow that?

angelsl abandoned this revision.Oct 20 2015, 12:05 AM

I guess if the warning's not too annoying, we can leave it then.

Revision Contents

PathSize
9 lines

Diff 37454

CMakeLists.txt

Context not available.
include(config-ix) include(config-ix)
if(MSVC) if(MSVC AND COMPILER_RT_HAS_W3_FLAG)
append_string_if(COMPILER_RT_HAS_W3_FLAG /W3 CMAKE_C_FLAGS CMAKE_CXX_FLAGS) # MSVC will give a warning if there is already another warning option.
# Remove any such option if present before appending /W3.
string(REGEX REPLACE " /W[0-4]" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
string(REGEX REPLACE " /W[0-4]" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W3")
compnerdUnsubmitted
Done
ReplyInline Actions

What happens if COMPILER_RT_HAS_W3_FLAG is set to false? In this case, you've cleared out the flag but not re-appended it. Or can that not occur?

compnerd: What happens if COMPILER_RT_HAS_W3_FLAG is set to false? In this case, you've cleared out the…
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W3")
else() else()
append_string_if(COMPILER_RT_HAS_WALL_FLAG -Wall CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_string_if(COMPILER_RT_HAS_WALL_FLAG -Wall CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
endif() endif()
Context not available.