This is an archive of the discontinued LLVM Phabricator instance.

Add call to find_package to load LLVM dependencies
ClosedPublic

Authored by hintonda on Oct 10 2015, 11:20 AM.

Download Raw Diff

Details

Reviewers

Commits

rGa2550e68a57d: Add call to find_package to load LLVM dependencies
rC261290: Add call to find_package to load LLVM dependencies
rL261290: Add call to find_package to load LLVM dependencies

Summary

ClangConfig requires LLVMConfig, so add find_package call in ClangConfig so find_package(clang REQUIRED CONFIG) will just work. This makes it easier for cmake based projects to use clang, e.g., tools using ClangTooling.

Diff Detail

Repository: rL LLVM

Event Timeline

hintonda updated this revision to Diff 37031.Oct 10 2015, 11:20 AM

hintonda retitled this revision from to Add call to find_package to load LLVM dependencies.

hintonda updated this object.

hintonda added a reviewer: chapuni.

hintonda added a subscriber: cfe-commits.

ping

I haven't worked in this. I guess it just works. :)

lgtm

This revision is now accepted and ready to land.Feb 9 2016, 4:16 PM

Great, thanks. Btw, I don't have commit access, so could you commit for me? thanks don

Ping,..

Could someone commit this for me?

Closed by commit rL261290: Add call to find_package to load LLVM dependencies (authored by rnk). · Explain WhyFeb 18 2016, 5:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

cmake/

modules/

ClangConfig.cmake

2 lines

Diff 48431

cfe/trunk/cmake/modules/ClangConfig.cmake

	# This file allows users to call find_package(Clang) and pick up our targets.			# This file allows users to call find_package(Clang) and pick up our targets.

	# Clang doesn't have any CMake configuration settings yet because it mostly			# Clang doesn't have any CMake configuration settings yet because it mostly
	# uses LLVM's. When it does, we should move this file to ClangConfig.cmake.in			# uses LLVM's. When it does, we should move this file to ClangConfig.cmake.in
	# and call configure_file() on it.			# and call configure_file() on it.

				find_package(LLVM REQUIRED CONFIG)

	# Provide all our library targets to users.			# Provide all our library targets to users.
	include("${CMAKE_CURRENT_LIST_DIR}/ClangTargets.cmake")			include("${CMAKE_CURRENT_LIST_DIR}/ClangTargets.cmake")