This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][MIPS] fix watchpoint searched on client side for same masked variables
ClosedPublic

Authored by mohit.bhakkad on Oct 8 2015, 3:15 AM.

Details

Summary

On MIPS architecture, it is possible to use same hardware register for 2 different variables with same watch mask(address & ~7).
wp_addr passed by server is sometime of other same masked variable, so we always rely on wp_hit_addr to search the
correct watchpoint.

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad retitled this revision from to [LLDB][MIPS] fix watchpoint searched on client side for same masked variables .
mohit.bhakkad updated this object.
mohit.bhakkad added reviewers: clayborg, jingham.
mohit.bhakkad set the repository for this revision to rL LLVM.
mohit.bhakkad added subscribers: jaydeep, bhushan, slthakur and 2 others.
brucem requested changes to this revision.Oct 8 2015, 3:29 AM
brucem added a reviewer: brucem.
brucem added a subscriber: brucem.
brucem added inline comments.
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
2108 ↗(On Diff #36838)

Missing a space between if and (.

This revision now requires changes to proceed.Oct 8 2015, 3:29 AM
clayborg accepted this revision.Oct 8 2015, 9:52 AM
clayborg edited edge metadata.

Add space in between if and opening ( and this is good to go.

This revision was automatically updated to reflect the committed changes.

Add space in between if and opening ( and this is good to go.

Thanks, addressed it while commiting.