This is an archive of the discontinued LLVM Phabricator instance.

commands: Use override instead of virtual.
ClosedPublic

Authored by brucem on Oct 7 2015, 2:43 AM.

Details

Summary

This removes many/most/all of the uses of virtual on functions
(but not destructors) in favor using 'override'.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 36720.Oct 7 2015, 2:43 AM
brucem retitled this revision from to commands: Use override instead of virtual..
brucem updated this object.
brucem added reviewers: clayborg, labath.
brucem added a subscriber: lldb-commits.
labath accepted this revision.Oct 7 2015, 2:49 AM
labath edited edge metadata.

Looks good. You can also fix a couple of style issues, if you feel like it (or just keep it in mind for next time).

source/Commands/CommandObjectMemory.cpp
381 ↗(On Diff #36720)

You might as well reformat this when you are touching it (line break after the type).

1719 ↗(On Diff #36720)

same here

source/Commands/CommandObjectProcess.cpp
179 ↗(On Diff #36720)

and here

This revision is now accepted and ready to land.Oct 7 2015, 2:49 AM
brucem updated this revision to Diff 36735.Oct 7 2015, 7:09 AM
brucem edited edge metadata.

Flag all destructors with override as appropriate. Also fix
the couple of code formatting issues pointed out by labath.

brucem updated this revision to Diff 36736.Oct 7 2015, 7:10 AM
brucem marked an inline comment as done.

Rebase forward.

brucem marked 2 inline comments as done.Oct 7 2015, 7:11 AM
clayborg accepted this revision.Oct 7 2015, 9:27 AM
clayborg edited edge metadata.
This revision was automatically updated to reflect the committed changes.