This is an archive of the discontinued LLVM Phabricator instance.

[PlaceSafeopints] Extract out `callsGCLeafFunction`, NFC
ClosedPublic

Authored by sanjoy on Oct 6 2015, 5:39 PM.

Diff Detail

Event Timeline

sanjoy updated this revision to Diff 36690.Oct 6 2015, 5:39 PM
sanjoy retitled this revision from to [PlaceSafeopints] Extract out `callsGCLeafFunction`, NFC.
sanjoy updated this object.
sanjoy added reviewers: reames, swaroop.sridhar.
sanjoy added a subscriber: llvm-commits.
sanjoy updated this revision to Diff 36694.Oct 6 2015, 5:58 PM
  • edit comment

Actually, I'm not sure Transform/Utils is the right place to put callsGCLeafFunction, I'll look for a better place.

reames accepted this revision.Oct 8 2015, 9:41 AM
reames edited edge metadata.

LGTM either in it's current location or somewhere in Analysis. I would suggest updating the documentation to reflect that most passes can and should ignore this information and that's effectively only used during lowering by the GC infrastructure. (a.k.a. the property doesn't effect optimization.)

This revision is now accepted and ready to land.Oct 8 2015, 9:41 AM
This revision was automatically updated to reflect the committed changes.