This is an archive of the discontinued LLVM Phabricator instance.

Differential D13415

Enable builtins build for MSVC
ClosedPublic

Authored by angelsl on Oct 3 2015, 10:45 AM.

Details

Reviewers
compnerd

Diff Detail

Event Timeline

angelsl updated this revision to Diff 36443.Oct 3 2015, 10:45 AM
angelsl retitled this revision from to Enable builtins build for MSVC.
angelsl updated this object.
angelsl added a reviewer: compnerd.
angelsl added subscribers: compnerd, llvm-commits.
compnerd accepted this revision.Oct 4 2015, 11:22 AM
compnerd edited edge metadata.

This seems fine, but I imagine that the other changes are needed before we can make this change?

This revision is now accepted and ready to land.Oct 4 2015, 11:22 AM
angelsl added a comment.Oct 4 2015, 11:29 AM

OK, thanks! Yeah, this should only land after the rest.

I'll make the fixes to the other changes.

compnerd closed this revision.Oct 10 2015, 10:59 AM

SVN r249948.

Revision Contents

PathSize
lib/
builtins/
2 lines

Diff 36443

lib/builtins/CMakeLists.txt

Context not available.
add_subdirectory(Darwin-excludes) add_subdirectory(Darwin-excludes)
add_subdirectory(macho_embedded) add_subdirectory(macho_embedded)
darwin_add_builtin_libraries(${BUILTIN_SUPPORTED_OS}) darwin_add_builtin_libraries(${BUILTIN_SUPPORTED_OS})
elseif (NOT WIN32 OR MINGW) else ()
foreach (arch ${BUILTIN_SUPPORTED_ARCH}) foreach (arch ${BUILTIN_SUPPORTED_ARCH})
if (CAN_TARGET_${arch}) if (CAN_TARGET_${arch})
# Filter out generic versions of routines that are re-implemented in # Filter out generic versions of routines that are re-implemented in
Context not available.