This is an archive of the discontinued LLVM Phabricator instance.

Differential D13412

Include Windows.h instead of winbase.h and windef.h
ClosedPublic

Authored by angelsl on Oct 3 2015, 10:43 AM.

Details

Reviewers
compnerd

Diff Detail

Event Timeline

angelsl updated this revision to Diff 36440.Oct 3 2015, 10:43 AM
angelsl retitled this revision from to Include wtypes.h to select arch (fix MSVC); remove winbase.h (unneeded).
angelsl updated this object.
angelsl added a reviewer: compnerd.
angelsl added subscribers: compnerd, llvm-commits.
compnerd edited edge metadata.Oct 4 2015, 11:05 AM

Can you include Windows.h please? winbase.h was included for VirtualQuery and VirtualProtect, though windows.h is recommended as the include. I believe that windef.h may be unneeded.

angelsl updated this revision to Diff 36482.Oct 4 2015, 11:48 PM
angelsl retitled this revision from Include wtypes.h to select arch (fix MSVC); remove winbase.h (unneeded) to Include Windows.h instead of winbase.h and windef.h.
angelsl edited edge metadata.
compnerd accepted this revision.Oct 5 2015, 7:01 PM
compnerd edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2015, 7:01 PM
compnerd closed this revision.Oct 5 2015, 9:35 PM

SVN r249373.

Revision Contents

PathSize
lib/
builtins/
4 lines

Diff 36482

lib/builtins/enable_execute_stack.c

Context not available.
#define HAVE_SYSCONF 1 #define HAVE_SYSCONF 1
#ifdef _WIN32 #ifdef _WIN32
#include <windef.h> #define WIN32_LEAN_AND_MEAN
#include <winbase.h> #include <Windows.h>
#else #else
#ifndef __APPLE__ #ifndef __APPLE__
#include <unistd.h> #include <unistd.h>
Context not available.