This is an archive of the discontinued LLVM Phabricator instance.

Differential D13279

Decorating virtual functions load with invariant.load
ClosedPublic

Authored by Prazek on Sep 29 2015, 11:23 PM.

Details

Reviewers
rjmccall
majnemer
nlewycky
rsmith

Diff Detail

Event Timeline

Prazek updated this revision to Diff 36069.Sep 29 2015, 11:23 PM
Prazek retitled this revision from to Decorating virtual functions load with invariant.load.
Prazek updated this object.
Prazek added reviewers: rsmith, majnemer, nlewycky, rjmccall.
Prazek added a subscriber: cfe-commits.
Prazek updated this revision to Diff 36125.Sep 30 2015, 10:25 AM
Prazek updated this revision to Diff 36130.Sep 30 2015, 11:06 AM
rsmith accepted this revision.Sep 30 2015, 11:21 AM
rsmith edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 11:21 AM
Prazek closed this revision.Sep 30 2015, 9:34 PM

Revision Contents

PathSize
lib/
CodeGen/
11 lines
test/
CodeGenCXX/
7 lines

Diff 36130

lib/CodeGen/ItaniumCXXABI.cpp

Show First 20 Lines • Show All 1,603 Lines • ▼ Show 20 Linesllvm::Value *ItaniumCXXABI::getVirtualFunctionPointer(CodeGenFunction &CGF,
if (CGF.SanOpts.has(SanitizerKind::CFIVCall)) if (CGF.SanOpts.has(SanitizerKind::CFIVCall))
CGF.EmitVTablePtrCheckForCall(MethodDecl, VTable, CGF.EmitVTablePtrCheckForCall(MethodDecl, VTable,
CodeGenFunction::CFITCK_VCall, Loc); CodeGenFunction::CFITCK_VCall, Loc);
uint64_t VTableIndex = CGM.getItaniumVTableContext().getMethodVTableIndex(GD); uint64_t VTableIndex = CGM.getItaniumVTableContext().getMethodVTableIndex(GD);
llvm::Value *VFuncPtr = llvm::Value *VFuncPtr =
CGF.Builder.CreateConstInBoundsGEP1_64(VTable, VTableIndex, "vfn"); CGF.Builder.CreateConstInBoundsGEP1_64(VTable, VTableIndex, "vfn");
return CGF.Builder.CreateAlignedLoad(VFuncPtr, CGF.getPointerAlign()); auto *Inst = CGF.Builder.CreateAlignedLoad(VFuncPtr, CGF.getPointerAlign());
// It's safe to add "invariant.load" without -fstrict-vtable-pointers, but it
// would not help in devirtualization.
if (CGM.getCodeGenOpts().OptimizationLevel > 0 &&
CGM.getCodeGenOpts().StrictVTablePointers)
Inst->setMetadata(llvm::LLVMContext::MD_invariant_load,
llvm::MDNode::get(CGM.getLLVMContext(),
llvm::ArrayRef<llvm::Metadata *>()));
return Inst;
} }
llvm::Value *ItaniumCXXABI::EmitVirtualDestructorCall( llvm::Value *ItaniumCXXABI::EmitVirtualDestructorCall(
CodeGenFunction &CGF, const CXXDestructorDecl *Dtor, CXXDtorType DtorType, CodeGenFunction &CGF, const CXXDestructorDecl *Dtor, CXXDtorType DtorType,
Address This, const CXXMemberCallExpr *CE) { Address This, const CXXMemberCallExpr *CE) {
assert(CE == nullptr || CE->arg_begin() == CE->arg_end()); assert(CE == nullptr || CE->arg_begin() == CE->arg_end());
assert(DtorType == Dtor_Deleting || DtorType == Dtor_Complete); assert(DtorType == Dtor_Deleting || DtorType == Dtor_Complete);
▲ Show 20 Lines • Show All 2,214 Lines • Show Last 20 Lines

test/CodeGenCXX/virtual-function-calls.cpp

// RUN: %clang_cc1 %s -triple %itanium_abi_triple -std=c++11 -emit-llvm -o - | FileCheck %s // RUN: %clang_cc1 %s -triple %itanium_abi_triple -std=c++11 -emit-llvm -o - | FileCheck %s
// RUN: %clang_cc1 %s -triple %itanium_abi_triple -std=c++11 -emit-llvm -o - -fstrict-vtable-pointers -O1 | FileCheck --check-prefix=CHECK-INVARIANT %s
// PR5021 // PR5021
namespace PR5021 { namespace PR5021 {
struct A { struct A {
virtual void f(char); virtual void f(char);
}; };
Show All 27 Linesnamespace Test1 {
} }
} }
namespace VirtualNoreturn { namespace VirtualNoreturn {
struct A { struct A {
[[noreturn]] virtual void f(); [[noreturn]] virtual void f();
}; };
// CHECK: @_ZN15VirtualNoreturn1f // CHECK-LABEL: @_ZN15VirtualNoreturn1f
// CHECK-INVARIANT-LABEL: define void @_ZN15VirtualNoreturn1f
void f(A *p) { void f(A *p) {
p->f(); p->f();
// CHECK: call {{.*}}void %{{[^#]*$}} // CHECK: call {{.*}}void %{{[^#]*$}}
// CHECK-NOT: unreachable // CHECK-NOT: unreachable
// CHECK-INVARIANT: load {{.*}} align 8, !invariant.load ![[EMPTY_NODE:[0-9]]]
} }
} }
// CHECK-INVARIANT: ![[EMPTY_NODE]] = !{}