This is an archive of the discontinued LLVM Phabricator instance.

Change lookup functions to const functions.
ClosedPublic

Authored by danielcdh on Sep 28 2015, 5:09 PM.

Details

Reviewers
dnovillo
davidxl
Summary

Change functions/pointers to const for better maintainability.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 35929.Sep 28 2015, 5:09 PM
danielcdh retitled this revision from to Change lookup functions to const functions..
danielcdh updated this object.
danielcdh added reviewers: dnovillo, davidxl.
danielcdh added a subscriber: llvm-commits.
danielcdh updated this revision to Diff 35932.Sep 28 2015, 6:24 PM

clang-format

dnovillo added inline comments.Sep 29 2015, 8:39 AM
include/llvm/ProfileData/SampleProf.h
195

Cleaner to use ErrorOr<unsigned> as the return value.

lib/Transforms/IPO/SampleProfile.cpp
218

Likewise here, change to return ErrorOr<unsigned>.

228

Could you leave the DEBUG() code in?

danielcdh updated this revision to Diff 35994.Sep 29 2015, 10:16 AM
danielcdh marked 3 inline comments as done.

Integrate comments.

dnovillo accepted this revision.Sep 29 2015, 10:49 AM
dnovillo edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 29 2015, 10:49 AM
danielcdh closed this revision.Sep 29 2015, 6:42 PM

submitted