This is an archive of the discontinued LLVM Phabricator instance.

Differential D13183

Change arc-cxx11-init-list.mm to work with upcoming SCEV changes.
ClosedPublic

Authored by sanjoy on Sep 25 2015, 4:01 PM.

Details

Reviewers
compnerd
Commits
rGa0bc8590fe01: Change arc-cxx11-init-list.mm to work with upcoming SCEV changes.
rC248632: Change arc-cxx11-init-list.mm to work with upcoming SCEV changes.
rL248632: Change arc-cxx11-init-list.mm to work with upcoming SCEV changes.
Summary

The store being checked for in arc-cxx11-init-list.mm is a store to an
unescaped alloca. After an uncoming change to ScalarEvolution, LLVM is
able to elide the store, so adjust the test accordingly.

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy updated this revision to Diff 35777.Sep 25 2015, 4:01 PM
sanjoy retitled this revision from to Change arc-cxx11-init-list.mm to work with upcoming SCEV changes..
sanjoy updated this object.
sanjoy added a reviewer: compnerd.
sanjoy added a subscriber: cfe-commits.
compnerd accepted this revision.Sep 25 2015, 4:05 PM
compnerd edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 4:05 PM
Closed by commit rL248632: Change arc-cxx11-init-list.mm to work with upcoming SCEV changes. (authored by sanjoy). · Explain WhySep 25 2015, 4:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
CodeGenObjCXX/
2 lines

Diff 35778

cfe/trunk/test/CodeGenObjCXX/arc-cxx11-init-list.mm

Show All 35 Lines
void external(); void external();
extern "C" void extended() { extern "C" void extended() {
const auto && temporary = { [I new] }; const auto && temporary = { [I new] };
external(); external();
} }
// CHECK: [[INSTANCE:%.*]] = {{.*}} call i8* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to i8* (i8*, i8*)*)(i8* {{.*}}, i8* {{.*}}) // CHECK: [[INSTANCE:%.*]] = {{.*}} call i8* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to i8* (i8*, i8*)*)(i8* {{.*}}, i8* {{.*}})
// CHECK-NEXT: [[CAST:%.*]] = bitcast [1 x %0*]* %{{.*}} to i8**
// CHECK-NEXT: store i8* [[INSTANCE]], i8** [[CAST]],
// CHECK: {{.*}} call void @_Z8externalv() // CHECK: {{.*}} call void @_Z8externalv()
// CHECK: {{.*}} call void @objc_release(i8* {{.*}}) // CHECK: {{.*}} call void @objc_release(i8* {{.*}})
std::initializer_list<I *> il = { [I new] }; std::initializer_list<I *> il = { [I new] };
// CHECK: [[POOL:%.*]] = {{.*}} call i8* @objc_autoreleasePoolPush() // CHECK: [[POOL:%.*]] = {{.*}} call i8* @objc_autoreleasePoolPush()
// CHECK: [[INSTANCE:%.*]] = {{.*}} call i8* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to i8* (i8*, i8*)*)(i8* {{.*}}, i8* {{.*}}) // CHECK: [[INSTANCE:%.*]] = {{.*}} call i8* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to i8* (i8*, i8*)*)(i8* {{.*}}, i8* {{.*}})
// CHECK-NEXT: store i8* [[INSTANCE]], i8** bitcast ([1 x %0*]* @_ZGR2il_ to i8**) // CHECK-NEXT: store i8* [[INSTANCE]], i8** bitcast ([1 x %0*]* @_ZGR2il_ to i8**)
// CHECK: {{.*}} call void @objc_autoreleasePoolPop(i8* [[POOL]]) // CHECK: {{.*}} call void @objc_autoreleasePoolPop(i8* [[POOL]])