This is an archive of the discontinued LLVM Phabricator instance.

Differential D13122

Enable SafeStack on all Linux platforms
ClosedPublic

Authored by eugenis on Sep 23 2015, 6:29 PM.

Details

Reviewers
samsonov
pcc
Summary

I don't see the point in limiting it to x86/x86_64 in the driver. It is only slightly less broken on x86 than on other platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis updated this revision to Diff 35579.Sep 23 2015, 6:29 PM
eugenis retitled this revision from to Enable SafeStack on all Linux platforms.
eugenis updated this object.
eugenis added reviewers: samsonov, pcc.
eugenis set the repository for this revision to rL LLVM.
eugenis added a subscriber: cfe-commits.
samsonov accepted this revision.Sep 23 2015, 11:01 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 23 2015, 11:01 PM
eugenis added a comment.Sep 24 2015, 10:24 AM

Thanks, committed as r248518 with a test.

eugenis closed this revision.Sep 24 2015, 10:24 AM

Revision Contents

PathSize
lib/
Driver/
2 lines

Diff 35579

lib/Driver/ToolChains.cpp

Context not available.
Res |= SanitizerKind::Address; Res |= SanitizerKind::Address;
Res |= SanitizerKind::KernelAddress; Res |= SanitizerKind::KernelAddress;
Res |= SanitizerKind::Vptr; Res |= SanitizerKind::Vptr;
Res |= SanitizerKind::SafeStack;
if (IsX86_64 || IsMIPS64 || IsAArch64) if (IsX86_64 || IsMIPS64 || IsAArch64)
Res |= SanitizerKind::DataFlow; Res |= SanitizerKind::DataFlow;
if (IsX86_64 || IsMIPS64) if (IsX86_64 || IsMIPS64)
Context not available.
Res |= SanitizerKind::Memory; Res |= SanitizerKind::Memory;
if (IsX86 || IsX86_64) { if (IsX86 || IsX86_64) {
Res |= SanitizerKind::Function; Res |= SanitizerKind::Function;
Res |= SanitizerKind::SafeStack;
} }
return Res; return Res;
} }
Context not available.