This is an archive of the discontinued LLVM Phabricator instance.

Differential D13045

AMDGPU: Don't handle invalid reg classes in helper functions
ClosedPublic

Authored by arsenm on Sep 21 2015, 10:36 PM.

Download Raw Diff

Details

Reviewers

• tstellarAMD

Summary

No tests hit these and it would be better to have checks like this explicit where they are used.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 35344.Sep 21 2015, 10:36 PM

arsenm retitled this revision from to AMDGPU: Don't handle invalid reg classes in helper functions.

arsenm updated this object.

arsenm added a reviewer: • tstellarAMD.

arsenm added a subscriber: llvm-commits.

Herald added a subscriber: arsenm. · View Herald TranscriptSep 21 2015, 10:36 PM

LGTM.

This revision is now accepted and ready to land.Sep 25 2015, 6:57 PM

r248655

Revision Contents

Path

Size

lib/

Target/

AMDGPU/

SIRegisterInfo.h

6 lines

Diff 35344

lib/Target/AMDGPU/SIRegisterInfo.h

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines	public:
unsigned getHWRegIndex(unsigned Reg) const override;		unsigned getHWRegIndex(unsigned Reg) const override;

/// \brief Return the 'base' register class for this register.		/// \brief Return the 'base' register class for this register.
/// e.g. SGPR0 => SReg_32, VGPR => VGPR_32 SGPR0_SGPR1 -> SReg_32, etc.		/// e.g. SGPR0 => SReg_32, VGPR => VGPR_32 SGPR0_SGPR1 -> SReg_32, etc.
const TargetRegisterClass *getPhysRegClass(unsigned Reg) const;		const TargetRegisterClass *getPhysRegClass(unsigned Reg) const;

/// \returns true if this class contains only SGPR registers		/// \returns true if this class contains only SGPR registers
bool isSGPRClass(const TargetRegisterClass *RC) const {		bool isSGPRClass(const TargetRegisterClass *RC) const {
if (!RC)
return false;

return !hasVGPRs(RC);		return !hasVGPRs(RC);
}		}

/// \returns true if this class ID contains only SGPR registers		/// \returns true if this class ID contains only SGPR registers
bool isSGPRClassID(unsigned RCID) const {		bool isSGPRClassID(unsigned RCID) const {
if (static_cast<int>(RCID) == -1)
return false;

return isSGPRClass(getRegClass(RCID));		return isSGPRClass(getRegClass(RCID));
}		}

/// \returns true if this class contains VGPR registers.		/// \returns true if this class contains VGPR registers.
bool hasVGPRs(const TargetRegisterClass *RC) const;		bool hasVGPRs(const TargetRegisterClass *RC) const;

/// \returns A VGPR reg class with the same width as \p SRC		/// \returns A VGPR reg class with the same width as \p SRC
const TargetRegisterClass *getEquivalentVGPRClass(		const TargetRegisterClass *getEquivalentVGPRClass(
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines