This is an archive of the discontinued LLVM Phabricator instance.

[DivergenceAnalysis] Separate the definition
ClosedPublic

Authored by volkan on Sep 18 2015, 4:27 PM.

Details

Reviewers
jingyue
Summary

Separated the definition so that other passes can use this analysis.

Diff Detail

Event Timeline

volkan updated this revision to Diff 35151.Sep 18 2015, 4:27 PM
volkan retitled this revision from to [DivergenceAnalysis] Separate the definition.
volkan updated this object.
volkan added a reviewer: jingyue.
volkan added a subscriber: llvm-commits.
jingyue requested changes to this revision.Sep 18 2015, 7:21 PM
jingyue edited edge metadata.
jingyue added inline comments.
include/llvm/Analysis/DivergenceAnalysis.h
15

These detailed header comments should remain in cpp. Add a very brief description in the header file.

Refer to the header comments in ScalarEvolution.h and ScalarEvolution.cpp.

This revision now requires changes to proceed.Sep 18 2015, 7:21 PM
volkan updated this revision to Diff 35158.Sep 18 2015, 9:09 PM
volkan edited edge metadata.

Moved the detailed comment to DivergenceAnalysis.cpp.

jingyue accepted this revision.Sep 18 2015, 9:11 PM
jingyue edited edge metadata.
jingyue added inline comments.
lib/Analysis/DivergenceAnalysis.cpp
11

Add a space before "It".

This revision is now accepted and ready to land.Sep 18 2015, 9:11 PM
volkan closed this revision.Sep 21 2015, 11:15 AM
volkan marked an inline comment as done.

Committed, rL248186.