This is an archive of the discontinued LLVM Phabricator instance.

Differential D12962

Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
ClosedPublic

Authored by tberghammer on Sep 18 2015, 7:29 AM.

Details

Reviewers
dawn
jingham
Commits
rG6b144354ff1c: Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
rLLDB248146: Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
rL248146: Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
Summary

Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler

Both GNU AS and LLVM emits language type DW_LANG_Mips_Assembler for all assembly code.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer updated this revision to Diff 35083.Sep 18 2015, 7:29 AM
tberghammer retitled this revision from to Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler.
tberghammer updated this object.
tberghammer added reviewers: jingham, dawn.
tberghammer added a subscriber: lldb-commits.
labath mentioned this in D12976: Update TestChangeProcessGroup to remove obsolete workaround..Sep 18 2015, 12:10 PM
dawn accepted this revision.Sep 18 2015, 12:56 PM
dawn edited edge metadata.

lgtm :)

This revision is now accepted and ready to land.Sep 18 2015, 12:56 PM
Closed by commit rL248146: Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler (authored by tberghammer). · Explain WhySep 21 2015, 3:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
source/
Target/
1 line

Diff 35218

lldb/trunk/source/Target/Target.cpp

Show First 20 Lines • Show All 1,892 Lines • ▼ Show 20 Lines
} }
TypeSystem * TypeSystem *
Target::GetScratchTypeSystemForLanguage (lldb::LanguageType language, bool create_on_demand) Target::GetScratchTypeSystemForLanguage (lldb::LanguageType language, bool create_on_demand)
{ {
if (Language::LanguageIsC(language) if (Language::LanguageIsC(language)
|| Language::LanguageIsObjC(language) || Language::LanguageIsObjC(language)
|| Language::LanguageIsCPlusPlus(language) || Language::LanguageIsCPlusPlus(language)
|| language == eLanguageTypeMipsAssembler // GNU AS and LLVM use it for all assembly code
|| language == eLanguageTypeUnknown) || language == eLanguageTypeUnknown)
return GetScratchClangASTContext(create_on_demand); return GetScratchClangASTContext(create_on_demand);
else else
return NULL; return NULL;
} }
UserExpression * UserExpression *
Target::GetUserExpressionForLanguage(const char *expr, Target::GetUserExpressionForLanguage(const char *expr,
▲ Show 20 Lines • Show All 2,109 Lines • Show Last 20 Lines