This is an archive of the discontinued LLVM Phabricator instance.

[ELF2] Fill up local symbols field correctly
ClosedPublic

Authored by davide on Sep 17 2015, 1:55 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 35035.Sep 17 2015, 1:55 PM
davide retitled this revision from to [ELF2] Fill up local symbols field correctly.
davide updated this object.
davide added a reviewer: rafael.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: llvm-commits.
rafael added inline comments.Sep 17 2015, 2:18 PM
ELF/Writer.cpp
700 ↗(On Diff #35035)

This doesn't handle SHN_XINDEX.

There is getExtendedSymbolTableIndex to help with that.

703 ↗(On Diff #35035)

Instead of the loop you should be able to do just Chunks[SecIndex], like we do in createSymbolBody.

davide updated this revision to Diff 35039.Sep 17 2015, 3:09 PM
davide removed rL LLVM as the repository for this revision.

Addressing Rafael's comments.

rafael added inline comments.Sep 17 2015, 3:16 PM
ELF/Writer.cpp
761 ↗(On Diff #35039)

This variable is now unused.

davide updated this revision to Diff 35040.Sep 17 2015, 3:20 PM
davide marked 2 inline comments as done.

Remove unused variable.

rafael accepted this revision.Sep 17 2015, 3:44 PM
rafael edited edge metadata.

LGTM with a nit.

ELF/Writer.cpp
764 ↗(On Diff #35040)

You have just used Section :-)

This revision is now accepted and ready to land.Sep 17 2015, 3:44 PM
This revision was automatically updated to reflect the committed changes.