Page MenuHomePhabricator

Fix caching for clang::Decl in DWARFASTParserClang
ClosedPublic

Authored by paulherman on Sep 17 2015, 10:39 AM.

Diff Detail

Event Timeline

paulherman retitled this revision from to Fix caching for clang::Decl in DWARFASTParserClang.
paulherman updated this object.
paulherman added a subscriber: lldb-commits.

Fix caching for clang::Decl in DWARFASTParserClang

Fix caching for clang::Decl in DWARFASTParserClang

Fixed small mistakes from previous commit.

tberghammer accepted this revision.Sep 17 2015, 11:29 AM
tberghammer edited edge metadata.

Looks good with minor comment inline

source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
3228–3239

I think using a switch would be both simpler and faster

This revision is now accepted and ready to land.Sep 17 2015, 11:29 AM
paulherman edited edge metadata.

Fix caching for clang::Decl in DWARFASTParserClang

Changed from std::set to switch. Rebased the patch.

paulherman closed this revision.Sep 17 2015, 12:33 PM