Fix several issues around dwo symbol file handling
This change all dwo related test failure on Linux x86_64
Differential D12804
Fix several issues around dwo symbol file handling tberghammer on Sep 11 2015, 8:36 AM. Authored by
Details Fix several issues around dwo symbol file handling This change all dwo related test failure on Linux x86_64
Diff Detail Event TimelineComment Actions Just can't check for zero in SymbolFileDWARF, other than that it looks good.
Comment Actions I should clarify: mach-o files do have functions at zero and these are legal DWARF and we need to read this DWARF correctly. We might be able to ask the SymbolFile's ObjectFile about this address and if it can be a valid function address using: AddressClass ObjectFile::GetAddressClass (lldb::addr_t file_addr);
Comment Actions Thank you for the clarification. I will commit in this patch without the change we discussed (ignoring 0 file address) and I will address that issue later. |
We might be able to ask the SymbolFile's ObjectFile if zero can be a valid code address. Then this could would become:
Or we might be able to ask the address class of an address:
We would need to make sure that an address of zero in a mach-o .o file returns eAddressClassCode or eAddressClassCodeAlternateISA type.