Include platform agnostic <GetOptInc.h> in the place of <getopt.h>

[krytarowski]

Summary

Problem caught on NetBSD with missing getopt_long_only(3).

[krytarowski]

Any interest?

[brucem]

tools/lldb-server/lldb-gdbserver.cpp

10 ↗

(On Diff #34399)

I suspect that this should #include "lldb/Host/HostGetOpt.h" instead, and that it should be down below with the other Host includes.

[krytarowski]

Put the include into proper line and use "" instead of <>.

[brucem]

tools/lldb-server/lldb-gdbserver.cpp

30 ↗

(On Diff #35923)

This should be lldb/Host/HostGetOpt.h and not lldb/Host/common/GetOptInc.h.

[krytarowski]

Use proper include.

lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp

 //===-- lldb-gdbserver.cpp --------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 // C Includes
 #include <errno.h>
-#include <getopt.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #ifndef _WIN32
 #include <signal.h>
 #include <unistd.h>
 #endif
 
 // C++ Includes
 
 // Other libraries and framework includes
 #include "llvm/ADT/StringRef.h"
 
 #include "lldb/Core/ConnectionMachPort.h"
 #include "lldb/Core/Error.h"
 #include "lldb/Core/PluginManager.h"
 #include "lldb/Host/ConnectionFileDescriptor.h"
+#include "lldb/Host/HostGetOpt.h"
 #include "lldb/Host/HostThread.h"
 #include "lldb/Host/OptionParser.h"
 #include "lldb/Host/Pipe.h"
 #include "lldb/Host/Socket.h"
 #include "lldb/Host/StringConvert.h"
 #include "lldb/Host/ThreadLauncher.h"
 #include "lldb/Target/Platform.h"
 #include "LLDBServerUtilities.h"