This is an archive of the discontinued LLVM Phabricator instance.

[Static Analyzer] Objective-C Generics checker improvements.
ClosedPublic

Authored by xazax.hun on Sep 8 2015, 12:17 PM.

Details

Summary

This patch contains several improvements to ObjCGenericsChecker:

  • Cover more cases with the type inference.
  • Make some functions significantly shorter and easier to understand
  • Minor fixes and cleanups

Diff Detail

Event Timeline

xazax.hun updated this revision to Diff 34237.Sep 8 2015, 12:17 PM
xazax.hun retitled this revision from to [Static Analyzer] Objective-C Generics checker improvements..
xazax.hun updated this object.
xazax.hun added a subscriber: cfe-commits.
zaks.anna accepted this revision.Sep 8 2015, 1:39 PM
zaks.anna edited edge metadata.
zaks.anna added inline comments.
lib/StaticAnalyzer/Checkers/ObjCGenericsChecker.cpp
226

http://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdparam

Is it possible to make sure that the names used in the description match with the parameter names?

230

Is this precondition checked?

This revision is now accepted and ready to land.Sep 8 2015, 1:39 PM
xazax.hun marked 2 inline comments as done.Sep 8 2015, 1:58 PM
This revision was automatically updated to reflect the committed changes.