This is an archive of the discontinued LLVM Phabricator instance.

Differential D12642

Improve portability, fix build issue on NetBSD
ClosedPublic

Authored by krytarowski on Sep 4 2015, 1:19 PM.

Download Raw Diff

Details

Reviewers

Commits

rG737e7d68bceb: Don't use bashism/kshism of test ==. From Kamil Rytarowski.
rL247512: Don't use bashism/kshism of test ==. From Kamil Rytarowski.

Summary

The "test" command, as well as the "[" command, are not required to know the "==" operator. Only a few implementations like bash and some versions of ksh support it.

Diff Detail

Repository: rL LLVM

Event Timeline

Of course we need to regenerate later autotools.

Still valid.

Closed by commit rL247512: Don't use bashism/kshism of test ==. From Kamil Rytarowski. (authored by joerg). · Explain WhySep 12 2015, 9:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

autoconf/

2 lines

2 lines

Diff 34629

llvm/trunk/autoconf/configure.ac

	Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
	dnl NOTE: This relies upon undocumented autoconf behavior.			dnl NOTE: This relies upon undocumented autoconf behavior.
	if test ${srcdir} != "." ; then			if test ${srcdir} != "." ; then
	if test -f ${srcdir}/include/llvm/Config/config.h ; then			if test -f ${srcdir}/include/llvm/Config/config.h ; then
	AC_MSG_ERROR([Already configured in ${srcdir}])			AC_MSG_ERROR([Already configured in ${srcdir}])
	fi			fi
	fi			fi

	dnl Quit if it is an in-source build			dnl Quit if it is an in-source build
	if test ${srcdir} == "." ; then			if test ${srcdir} = "." ; then
	AC_MSG_ERROR([In-source builds are not allowed. Please configure from a separate build directory!])			AC_MSG_ERROR([In-source builds are not allowed. Please configure from a separate build directory!])
	fi			fi

	dnl Default to empty (i.e. assigning the null string to) CFLAGS and CXXFLAGS,			dnl Default to empty (i.e. assigning the null string to) CFLAGS and CXXFLAGS,
	dnl instead of the autoconf default (for example, '-g -O2' for CC=gcc).			dnl instead of the autoconf default (for example, '-g -O2' for CC=gcc).
	: ${CFLAGS=}			: ${CFLAGS=}
	: ${CXXFLAGS=}			: ${CXXFLAGS=}

	▲ Show 20 Lines • Show All 2,155 Lines • Show Last 20 Lines

llvm/trunk/configure

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 2,027 Lines • ▼ Show 20 Lines
	if test ${srcdir} != "." ; then			if test ${srcdir} != "." ; then
	if test -f ${srcdir}/include/llvm/Config/config.h ; then			if test -f ${srcdir}/include/llvm/Config/config.h ; then
	{ { echo "$as_me:$LINENO: error: Already configured in ${srcdir}" >&5			{ { echo "$as_me:$LINENO: error: Already configured in ${srcdir}" >&5
	echo "$as_me: error: Already configured in ${srcdir}" >&2;}			echo "$as_me: error: Already configured in ${srcdir}" >&2;}
	{ (exit 1); exit 1; }; }			{ (exit 1); exit 1; }; }
	fi			fi
	fi			fi

	if test ${srcdir} == "." ; then			if test ${srcdir} = "." ; then
	{ { echo "$as_me:$LINENO: error: In-source builds are not allowed. Please configure from a separate build directory!" >&5			{ { echo "$as_me:$LINENO: error: In-source builds are not allowed. Please configure from a separate build directory!" >&5
	echo "$as_me: error: In-source builds are not allowed. Please configure from a separate build directory!" >&2;}			echo "$as_me: error: In-source builds are not allowed. Please configure from a separate build directory!" >&2;}
	{ (exit 1); exit 1; }; }			{ (exit 1); exit 1; }; }
	fi			fi

	: ${CFLAGS=}			: ${CFLAGS=}
	: ${CXXFLAGS=}			: ${CXXFLAGS=}

	▲ Show 20 Lines • Show All 17,337 Lines • Show Last 20 Lines