This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Re-justify workaround and fix worked around problem
ClosedPublic

Authored by arsenm on Sep 1 2015, 6:56 PM.

Details

Reviewers
tstellarAMD
Summary

When buffer resource descriptors were built, the upper two components
of the descriptor were first composed into a 64-bit register because
legalizeOperands assumed all operands had the same register class.
Fix that problem, but keep the workaround. I'm not sure anything
actually is actually emitting such a REG_SEQUENCE now.

If multiple resource descriptors are set up with different base
pointers, this is copied with a single s_mov_b64. We probably
should fix this better by recognizing a pair of s_mov_b32 later,
but for now delete the dead code.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 33776.Sep 1 2015, 6:56 PM
arsenm retitled this revision from to AMDGPU: Re-justify workaround and fix worked around problem.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Sep 25 2015, 7:23 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Sep 25 2015, 7:23 AM
arsenm closed this revision.Sep 25 2015, 10:10 AM

r248585