This is an archive of the discontinued LLVM Phabricator instance.

createScalarInitialization: Always store PHI-node value
ClosedPublic

Authored by grosser on Aug 29 2015, 3:36 PM.

Details

Summary

The current code really tries hard to use getNewScalarValue(), which checks if
not the original value, but a possible copy or demoted value needs to be stored.
In this calling context it seems, that we _always_ use the ScalarValue that
comes form the incoming PHI node, but never any other value. As also no test
cases fail, it seems right to just drop this call to getNewScalarValue and
remove the parameters that are not needed any more.

Diff Detail

Event Timeline

grosser updated this revision to Diff 33518.Aug 29 2015, 3:36 PM
grosser retitled this revision from to createScalarInitialization: Always store PHI-node value.
grosser updated this object.
grosser added a reviewer: jdoerfert.
grosser added subscribers: llvm-commits, pollydev.
jdoerfert edited edge metadata.Aug 30 2015, 6:57 AM

I am unsure and haven't tested it but don't we have to go back if we want to support parallel code generation?

This revision was automatically updated to reflect the committed changes.