LLD: ELF/AMDGPU: Text section should be called .hsatext

[atanasyan]

LGTM

lld/trunk/lib/ReaderWriter/ELF/AMDGPU/AMDGPUTargetHandler.h

public:
 
   void assignSectionsToSegments() override;
 
   /// \brief Gets or creates a section.
   AtomSection<ELF64LE> *
   createSection(StringRef name, int32_t contentType,
                 DefinedAtom::ContentPermissions contentPermissions,
                 TargetLayout::SectionOrder sectionOrder) override {
-    if (name == ".text")
+    if (name == ".hsatext")
       return new (_allocator) HSATextSection(_ctx);
 
     if (name == ".note")
       contentType = DefinedAtom::typeRONote;
 
     return TargetLayout::createSection(name, contentType, contentPermissions,
                                        sectionOrder);
   }

lld/trunk/lib/ReaderWriter/ELF/AMDGPU/AMDGPUTargetHandler.cpp

std::unique_ptr<Writer> AMDGPUTargetHandler::getWriter() {
   case llvm::ELF::ET_REL:
     llvm_unreachable("TODO: support -r mode");
   default:
     llvm_unreachable("unsupported output type");
   }
 }
 
 HSATextSection::HSATextSection(const ELFLinkingContext &ctx)
-    : AtomSection(ctx, ".text", DefinedAtom::typeCode, 0, 0) {
+    : AtomSection(ctx, ".hsatext", DefinedAtom::typeCode, 0, 0) {
   _type = SHT_PROGBITS;
   _flags = SHF_ALLOC | SHF_WRITE | SHF_EXECINSTR | SHF_AMDGPU_HSA_AGENT |
            SHF_AMDGPU_HSA_CODE;
 
   // FIXME: What alignment should we use here?
   _alignment = 4096;
 }
 
 void AMDGPUTargetLayout::assignSectionsToSegments() {
 
   TargetLayout::assignSectionsToSegments();
   for (OutputSection<ELF64LE> *osi : _outputSections) {
     for (Section<ELF64LE> *section : osi->sections()) {
       StringRef InputSectionName = section->inputSectionName();
-      if (InputSectionName != ".text")
+      if (InputSectionName != ".hsatext")
         continue;
 
       Segment<ELF64LE> *segment = new (_allocator) Segment<ELF64LE>(
           _ctx, "PT_AMDGPU_HSA_LOAD_CODE_AGENT", PT_AMDGPU_HSA_LOAD_CODE_AGENT);
       _segments.push_back(segment);
       assert(segment);
       segment->append(section);
     }
   }
 }
 
 } // namespace elf
 } // namespace lld

lld/trunk/test/elf/AMDGPU/hsa.test

 # RUN: yaml2obj -format=elf %s > %t.obj
 # RUN: lld -flavor gnu -target amdgcn--hsa %t.obj -o %t.exe --noinhibit-exec
 # RUN: llvm-readobj -h -program-headers -s -symbols %t.exe | FileCheck %s
 
 # CHECK: ElfHeader {
 # CHECK:  Ident {
 # CHECK: Class: 64-bit (0x2)
 # CHECK: DataEncoding: LittleEndian (0x1)
 # CHECK: Machine: EM_AMDGPU (0xE0)
 
 
 # CHECK: Section {
-# CHECK: Name: .text
+# CHECK: Name: .hsatext
 # CHECK: Type: SHT_PROGBITS (0x1)
 # CHECK: Flags [ (0xC00007
 # CHECK: SHF_ALLOC (0x2)
 # CHECK: SHF_AMDGPU_HSA_AGENT (0x800000)
 # CHECK: SHF_AMDGPU_HSA_CODE (0x400000)
 # CHECK: SHF_EXECINSTR (0x4)
 # CHECK: SHF_WRITE (0x1)
 #

 ---
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   OSABI:           ELFOSABI_GNU
   Type:            ET_REL
   Machine:         EM_AMDGPU
 Sections:
-  - Name:            .text
+  - Name:            .hsatext
     Type:            SHT_PROGBITS
     Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
     AddressAlign:    0x0000000000000004
     Content:         ''
   - Name:            .note
     Type:            SHT_NOTE
     AddressAlign:    0x0000000000000001
     Content:         '00'
 Symbols:
   Local:
     - Name:            kernel
       Type:            STT_GNU_IFUNC
-      Section:         .text
+      Section:         .hsatext
 ...