Make ProcessGDBRemote get a //copy// of platform Unix signals.

[chaoren]

Summary

Update to http://reviews.llvm.org/rL243618.

[tberghammer]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

853 ↗

(On Diff #33386)

I think it would be better to change SetUnixSignals to create the copy (or force the client side copy with some magic with rvalue references) because this error will happen almost every time somebody calls SetUnixSignals.

[labath]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

853 ↗

(On Diff #33386)

If the platform is supposed to hold signals, which are not to be changed by its users, I would have it hand out std::shared_ptr<CONST UnixSignals> (or even const UnixSignals & ?). Then the users will be forced to make a copy if they want to do anything to them.

[chaoren]

• Force client side copy.

[chaoren]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

853 ↗

(On Diff #33386)

If the platform is supposed to hold signals, which are not to be changed by its users

I think in my original discussion with Greg, we decided that it would be a good idea if we allow setting suppress/stop/notify for the platform signal set, and will be inherited by any process signal set created from it.

[chaoren]

• ProcessGDBRemote should automatically get a copy of GDBRemoteSignals.

[clayborg]

We do want processes to have individual copies that are copied from the platform. Does this actually make a copy? I don't see the copy.

[chaoren]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

2910 ↗

(On Diff #33485)

Here's the copy.

lldb/trunk/include/lldb/Target/Process.h

#endif
     ///
     /// @return
     ///     Returns an error object.
     //------------------------------------------------------------------
     Error
     Signal (int signal);
 
     void
-    SetUnixSignals(const lldb::UnixSignalsSP &signals_sp);
+    SetUnixSignals(lldb::UnixSignalsSP &&signals_sp);
 
     const lldb::UnixSignalsSP &
     GetUnixSignals();
 
     //==================================================================
     // Plug-in Process Control Overrides
     //==================================================================
 

lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp

 }
 
 void
 ProcessElfCore::Clear()
 {
     m_thread_list.Clear();
     m_os = llvm::Triple::UnknownOS;
 
-    static const auto s_default_unix_signals_sp = std::make_shared<UnixSignals>();
-    SetUnixSignals(s_default_unix_signals_sp);
+    SetUnixSignals(std::make_shared<UnixSignals>());
 }
 
 void
 ProcessElfCore::Initialize()
 {
     static std::once_flag g_once_flag;
 
     std::call_once(g_once_flag, []()

lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

public:
     DoSignal (int signal) override;
 
     Error
     DoDestroy () override;
 
     void
     RefreshStateAfterStop() override;
 
+    void
+    SetUnixSignals(const lldb::UnixSignalsSP &signals_sp);
+
     //------------------------------------------------------------------
     // Process Queries
     //------------------------------------------------------------------
     bool
     IsAlive () override;
 
     lldb::addr_t
     GetImageInfoAddress() override;

lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

// Scope the lock
 
         // Add this stop packet to the stop packet stack
         // This stack will get popped and examined when we switch to the
         // Stopped state
         m_stop_packet_stack.push_back(response);
     }
 }
 
+void
+ProcessGDBRemote::SetUnixSignals(const UnixSignalsSP &signals_sp)
+{
+    Process::SetUnixSignals(std::make_shared<GDBRemoteSignals>(signals_sp));
+}
+
 //------------------------------------------------------------------
 // Process Queries
 //------------------------------------------------------------------
 
 bool
 ProcessGDBRemote::IsAlive ()
 {
     return m_gdb_comm.IsConnected() && m_private_state.GetValue() != eStateExited;

lldb/trunk/source/Target/Process.cpp

if (error.Success())
         error = DoSignal(signal);
         if (error.Success())
             DidSignal();
     }
     return error;
 }
 
 void
-Process::SetUnixSignals (const UnixSignalsSP &signals_sp)
+Process::SetUnixSignals(UnixSignalsSP &&signals_sp)
 {
     assert (signals_sp && "null signals_sp");
     m_unix_signals_sp = signals_sp;
 }
 
 const lldb::UnixSignalsSP &
 Process::GetUnixSignals ()
 {