CFL AA Bugfix -- Mark no-args function return values as unknown values

[george.burgess.iv]

Summary

Fix an issue where we wouldn't properly note that the return value of a no-args function could alias something an escaped variable.

(So, for the given test case, we wouldn't properly detect that %Escapes and %Retrieved may alias)

Thanks to Chandler, Richard, and Nick for pinging me about this! :)

[hfinkel]

lib/Analysis/CFLAliasAnalysis.cpp

418

Is this necessary if the function returns void?

[george.burgess.iv]

Added type != void && len(args) == 0 type check

lib/Analysis/CFLAliasAnalysis.cpp

418

Good catch!

[hfinkel]

LGTM.

[george.burgess.iv]

r246240 -- thanks!

lib/Analysis/CFLAliasAnalysis.cpp

for (auto *Fn : Fns) {
           Output.push_back(Edge(MainVal, SubVal, EdgeType::Assign, NewAttrs));
         }
       }
     }
     return true;
   }
 
   template <typename InstT> void visitCallLikeInst(InstT &Inst) {
+    // TODO: Add support for noalias args/all the other fun function attributes
+    // that we can tack on.
     SmallVector<Function *, 4> Targets;
     if (getPossibleTargets(&Inst, Targets)) {
       if (tryInterproceduralAnalysis(Targets, &Inst, Inst.arg_operands()))
         return;
       // Cleanup from interprocedural analysis
       Output.clear();
     }
 
+    // Because the function is opaque, we need to note that anything
+    // could have happened to the arguments, and that the result could alias
+    // just about anything, too.
+    // The goal of the loop is in part to unify many Values into one set, so we
+    // don't care if the function is void there.
     for (Value *V : Inst.arg_operands())
       Output.push_back(Edge(&Inst, V, EdgeType::Assign, AttrAll));
+    if (Inst.getNumArgOperands() == 0 &&
+        Inst.getType() != Type::getVoidTy(Inst.getContext()))
+      Output.push_back(Edge(&Inst, &Inst, EdgeType::Assign, AttrAll));
   }
 
   void visitCallInst(CallInst &Inst) { visitCallLikeInst(Inst); }
 
   void visitInvokeInst(InvokeInst &Inst) { visitCallLikeInst(Inst); }
 
   // Because vectors/aggregates are immutable and unaddressable,
   // there's nothing we can do to coax a value out of them, other

test/Analysis/CFLAliasAnalysis/opaque-call-alias.ll

+; We previously had a case where we would put results from a no-args call in
+; its own stratified set. This would make cases like the one in @test say that
+; nothing (except %Escapes and %Arg) can alias
+
+; RUN: opt < %s -cfl-aa -aa-eval -print-may-aliases -disable-output 2>&1 | FileCheck %s
+
+; CHECK:     Function: test
+; CHECK:     MayAlias: i8* %Arg, i8* %Escapes
+; CHECK:     MayAlias: i8* %Arg, i8* %Retrieved
+; CHECK:     MayAlias: i8* %Escapes, i8* %Retrieved
+define void @test(i8* %Arg) {
+  %Noalias = alloca i8
+  %Escapes = alloca i8
+  call void @set_thepointer(i8* %Escapes)
+  %Retrieved = call i8* @get_thepointer()
+  ret void
+}
+
+declare void @set_thepointer(i8* %P)
+declare i8* @get_thepointer()