This is an archive of the discontinued LLVM Phabricator instance.

Treat cleanup errors separately from test failures
ClosedPublic

Authored by zturner on Aug 25 2015, 11:45 AM.

Details

Reviewers
spyffe
clayborg
Summary

There is a certain class of test failures that arise as a result of errors that occur during cleanup. For the most part, these don't indicate test failures and so it's useful to distinguish them from test failures. This patch creates a new category of error, called a CleanupError, that is handled (and reported) independently of whether or not any individual tests failed.

This is especially important when there is a directory that contains multiple test suites, because previously a cleanup error on the first suite would automatically cause subsequent suites in the same directory to not run, as a result of exception propagation.

Diff Detail

Event Timeline

zturner updated this revision to Diff 33096.Aug 25 2015, 11:45 AM
zturner retitled this revision from to Treat cleanup errors separately from test failures.
zturner updated this object.
zturner added reviewers: clayborg, spyffe.
zturner added a subscriber: lldb-commits.
zturner updated this revision to Diff 33131.Aug 25 2015, 2:48 PM

Upload full diffs with context.

clayborg accepted this revision.Aug 26 2015, 9:43 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Aug 26 2015, 9:43 AM
zturner closed this revision.Oct 15 2015, 1:52 PM