This is an archive of the discontinued LLVM Phabricator instance.

Avoid LoopConvertCheck replacements in template instantiations.
ClosedPublic

Authored by angelgarcia on Aug 25 2015, 7:50 AM.

Diff Detail

Event Timeline

angelgarcia retitled this revision from to Avoid LoopConvertCheck replacements in template instantiations..
angelgarcia updated this object.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
alexfh accepted this revision.Aug 25 2015, 8:02 AM
alexfh edited edge metadata.

Looks good with a comment.

test/clang-tidy/modernize-loop-convert-extra.cpp
636

Please add a test to ensure that loops over non-dependent container types in templates are still converted.

This revision is now accepted and ready to land.Aug 25 2015, 8:02 AM
angelgarcia edited edge metadata.

Add test.

Thanks! Still looks good.

angelgarcia closed this revision.Aug 25 2015, 8:44 AM