This is an archive of the discontinued LLVM Phabricator instance.

Add replace-auto_ptr check.
ClosedPublic

Authored by angelgarcia on Aug 24 2015, 9:05 AM.

Details

Summary

Migrate replace-auto_ptr check from clang-modernize to modernize module in clang-tidy.

Diff Detail

Event Timeline

angelgarcia retitled this revision from to Add replace-auto_ptr check..
angelgarcia updated this object.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
alexfh added inline comments.Aug 24 2015, 3:47 PM
clang-tidy/modernize/ReplaceAutoPtrCheck.h
21

Please add a class comment describing what the check does and why.

Add check description.

alexfh accepted this revision.Aug 25 2015, 5:57 AM
alexfh edited edge metadata.

Looks good with one nit.

Thank you!

test/clang-tidy/modernize-replace-auto-ptr.cpp
13

Please use the full message including the [check-name] once. Please also truncate all other patterns after deprecated, to make them fit 80 columns.

This revision is now accepted and ready to land.Aug 25 2015, 5:57 AM
angelgarcia edited edge metadata.

Use the full message once in the test, and truncate all the other patterns.

angelgarcia closed this revision.Aug 25 2015, 6:05 AM