Page MenuHomePhabricator

Assume intrinsic handling in globalopt
ClosedPublic

Authored by Prazek on Aug 22 2015, 9:00 PM.

Details

Diff Detail

Event Timeline

Prazek updated this revision to Diff 32914.Aug 22 2015, 9:00 PM
Prazek retitled this revision from to Assume intrinsic handling in globalopt.
Prazek updated this object.
Prazek added reviewers: nlewycky, rsmith, majnemer.
Prazek added a subscriber: llvm-commits.
nlewycky accepted this revision.Aug 24 2015, 5:10 PM
nlewycky edited edge metadata.

This looks correct, but probably not enough.

The point of assumes is that you need them because you're assuming something you don't know, and which globalopt probably also doesn't know. For instance, that a load from an external is equal to some particular value. Globalopt will stop processing when it sees that load, and never get to the assume.

test/Transforms/GlobalOpt/assume.ll
12

What's up with the personality? Is this needed for the testcase?

This revision is now accepted and ready to land.Aug 24 2015, 5:10 PM
Prazek marked an inline comment as done.Aug 24 2015, 6:27 PM
Prazek added inline comments.
test/Transforms/GlobalOpt/assume.ll
12

ok, got rid of it #copypasting

Prazek closed this revision.Aug 24 2015, 6:37 PM
Prazek marked 2 inline comments as done.