This is an archive of the discontinued LLVM Phabricator instance.

[NFC][tests][AIX] XFAIL test for lack of visibility support
ClosedPublic

Authored by Jake-Egan on Mar 25 2022, 7:10 PM.

Details

Summary

With the addition of __attribute__((visibility("hidden"))) to the test, the test fails because AIX's current default behaviour is to ignore hidden visibility, so the expected error is not seen. This patch marks the test XFAIL on AIX for now.

Diff Detail

Event Timeline

Jake-Egan created this revision.Mar 25 2022, 7:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 7:10 PM
Jake-Egan requested review of this revision.Mar 25 2022, 7:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 7:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Mar 25 2022, 7:14 PM
Jake-Egan added a reviewer: cebowleratibm.
Jake-Egan updated this revision to Diff 418369.Mar 25 2022, 7:16 PM

Updated the comment.

cebowleratibm accepted this revision.Mar 28 2022, 6:36 AM

The AIX default of ignoring source-level visibility is problematic. I agree the test should be xfailed for AIX.

You can put [NFC] and [tests] to the commit. Should be safe to commit.

This revision is now accepted and ready to land.Mar 28 2022, 6:36 AM
Jake-Egan retitled this revision from [AIX] XFAIL test for lack of visibility support to [NFC][tests][AIX] XFAIL test for lack of visibility support.Mar 28 2022, 6:40 AM