Removal of Intersection with AssumedContext in calculateMinMaxAccess

[pbhatu]

Summary

We see -3.17% reduction in compile time of 3mm and -17.87% when compiled with -DPOLYBENCH_USE_C99_PROTO flag.
We also do not get any regressions.

[grosser]

We see -3.17% reduction in compile time of 3mm and -17.87% when compiled with -DPOLYBENCH_USE_C99_PROTO flag.
We also do not get any regressions.

http://reviews.llvm.org/D12198

Files:

lib/Analysis/ScopInfo.cpp

Index: lib/Analysis/ScopInfo.cpp

• lib/Analysis/ScopInfo.cpp

+++ lib/Analysis/ScopInfo.cpp
@@ -1302,8 +1302,8 @@

                                Scop::MinMaxVectorTy &MinMaxAccesses) {

Accesses = isl_union_map_intersect_domain(Accesses, Domains);

+ isl_set_free(AssumedContext);

isl_union_set *Locations = isl_union_map_range(Accesses);

• Locations = isl_union_set_intersect_params(Locations, AssumedContext); Locations = isl_union_set_coalesce(Locations); Locations = isl_union_set_detect_equalities(Locations); bool Valid = (0 == isl_union_set_foreach_set(Locations, buildMinMaxAccess,

Hi Pratik,

please do not even pass the assumedContext to calculateMinMaxAccess.

Tobias

[pbhatu]

Don't pass the assumedContext to calculateMinMaxAccess.

polly/trunk/lib/Analysis/ScopInfo.cpp

static __isl_give isl_set *getAccessDomain(MemoryAccess *MA) {
   isl_set *Domain = MA->getStatement()->getDomain();
   Domain = isl_set_project_out(Domain, isl_dim_set, 0, isl_set_n_dim(Domain));
   return isl_set_reset_tuple_id(Domain);
 }
 
 /// @brief Wrapper function to calculate minimal/maximal accesses to each array.
 static bool calculateMinMaxAccess(__isl_take isl_union_map *Accesses,
                                   __isl_take isl_union_set *Domains,
-                                  __isl_take isl_set *AssumedContext,
                                   Scop::MinMaxVectorTy &MinMaxAccesses) {
 
   Accesses = isl_union_map_intersect_domain(Accesses, Domains);
   isl_union_set *Locations = isl_union_map_range(Accesses);
-  Locations = isl_union_set_intersect_params(Locations, AssumedContext);
   Locations = isl_union_set_coalesce(Locations);
   Locations = isl_union_set_detect_equalities(Locations);
   bool Valid = (0 == isl_union_set_foreach_set(Locations, buildMinMaxAccess,
                                                &MinMaxAccesses));
   isl_union_set_free(Locations);
   return Valid;
 }
 
for (AliasGroupTy &AG : AliasGroups) {
     MinMaxAccessesNonReadOnly.reserve(AG.size());
 
     isl_union_map *Accesses = isl_union_map_empty(getParamSpace());
 
     // AG contains only non read only accesses.
     for (MemoryAccess *MA : AG)
       Accesses = isl_union_map_add_map(Accesses, MA->getAccessRelation());
 
-    bool Valid = calculateMinMaxAccess(
-        Accesses, getDomains(), getAssumedContext(), MinMaxAccessesNonReadOnly);
+    bool Valid = calculateMinMaxAccess(Accesses, getDomains(),
+                                       MinMaxAccessesNonReadOnly);
 
     // Bail out if the number of values we need to compare is too large.
     // This is important as the number of comparisions grows quadratically with
     // the number of values we need to compare.
     if (!Valid || (MinMaxAccessesNonReadOnly.size() + !ReadOnlyPairs.empty() >
                    RunTimeChecksMaxArraysPerGroup))
       return false;
 
     // Calculate minimal and maximal accesses for read only accesses.
     MinMaxAccessesReadOnly.reserve(ReadOnlyPairs.size());
     Accesses = isl_union_map_empty(getParamSpace());
 
     for (const auto &ReadOnlyPair : ReadOnlyPairs)
       for (MemoryAccess *MA : ReadOnlyPair.second)
         Accesses = isl_union_map_add_map(Accesses, MA->getAccessRelation());
 
-    Valid = calculateMinMaxAccess(Accesses, getDomains(), getAssumedContext(),
-                                  MinMaxAccessesReadOnly);
+    Valid =
+        calculateMinMaxAccess(Accesses, getDomains(), MinMaxAccessesReadOnly);
 
     if (!Valid)
       return false;
   }
 
   return true;
 }