Remove reference.

[angelgarcia]

Summary

Remove a reference where a value was intended (its being initialized with std::move).

[alexfh]

clang-tidy/modernize/UseNullptrCheck.cpp

178

Please use ArrayRef<StringRef> here and store it in the class.

[angelgarcia]

Use ArrayRef.

[alexfh]

Thanks! LG

[alexfh]

Committed revision 245471.

clang-tidy/modernize/UseNullptrCheck.cpp

 /// explicit casts exist between the found top-most explicit cast and the
 /// possibly more than one nested implicit cast. This visitor finds all cast
 /// sequences with an implicit cast to null within and creates a replacement
 /// leaving the outermost explicit cast unchanged to avoid introducing
 /// ambiguities.
 class CastSequenceVisitor : public RecursiveASTVisitor<CastSequenceVisitor> {
 public:
   CastSequenceVisitor(ASTContext &Context,
-                      SmallVector<StringRef, 1> UserNullMacros,
+                      ArrayRef<StringRef> UserNullMacros,
                       ClangTidyCheck &check)
       : SM(Context.getSourceManager()), Context(Context),
-        UserNullMacros(std::move(UserNullMacros)), Check(check),
+        UserNullMacros(UserNullMacros), Check(check),
         FirstSubExpr(nullptr), PruneSubtree(false) {}
 
   bool TraverseStmt(Stmt *S) {
     // Stop traversing down the tree if requested.
     if (PruneSubtree) {
       PruneSubtree = false;
       return true;
     }
bool findContainingAncestor(ast_type_traits::DynTypedNode Start,
     }
 
     llvm_unreachable("findContainingAncestor");
   }
 
 private:
   SourceManager &SM;
   ASTContext &Context;
-  const SmallVector<StringRef, 1> &UserNullMacros;
+  ArrayRef<StringRef> UserNullMacros;
   ClangTidyCheck &Check;
   Expr *FirstSubExpr;
   bool PruneSubtree;
 };
 
 UseNullptrCheck::UseNullptrCheck(StringRef Name, ClangTidyContext *Context)
     : ClangTidyCheck(Name, Context) {
   StringRef UserMacrosStr = Options.get("UserNullMacros", "");