[compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2.

[compnerd]

Can you define an use a macro similar to ARM_EABI_FNALIAS in int_lib.h please?

[jmgao]

Add and use an FNALIAS macro

[compnerd]

lib/builtins/comparedf2.c

83 ↗

(On Diff #32450)

Use /* */, since I don't believe we are forcing C99. Similar throughout.

lib/builtins/int_lib.h

23 ↗

(On Diff #32450)

clang-format this line please.

[jmgao]

lib/builtins/comparedf2.c

83 ↗

(On Diff #32450)

These files only have // comments, and there are a bunch of other ones that are similar.

[compnerd]

lib/builtins/comparedf2.c

83 ↗

(On Diff #32575)

Okay, seems fair enough

[asl]

lib/builtins/int_lib.h

23 ↗

(On Diff #32575)

What's in darwin case? Shall we define these aliases there as well?

[jmgao]

lib/builtins/int_lib.h

23 ↗

(On Diff #32575)

This will be defined for everything that includes int_lib.h

[jmgao]

lib/builtins/int_lib.h

23 ↗

(On Diff #32575)

Sorry, misread your comment. I'm not sure what should happen in darwin.

[compnerd]

lib/builtins/int_lib.h

23 ↗

(On Diff #32575)

Darwin did at one point use libgcc, so I don't think that this would be problematic. Do you have some reason to believe it would be? We could easily conditionalise the aliases if that is the case.

compiler-rt/trunk/lib/builtins/comparedf2.c

__ledf2(fp_t a, fp_t b) {
     // sign-magnitude representation, then this flip is incorrect).
     else {
         if (aInt > bInt) return LE_LESS;
         else if (aInt == bInt) return LE_EQUAL;
         else return LE_GREATER;
     }
 }
 
+// Alias for libgcc compatibility
+FNALIAS(__cmpdf2, __ledf2);
+
 enum GE_RESULT {
     GE_LESS      = -1,
     GE_EQUAL     =  0,
     GE_GREATER   =  1,
     GE_UNORDERED = -1   // Note: different from LE_UNORDERED
 };
 
 COMPILER_RT_ABI enum GE_RESULT

compiler-rt/trunk/lib/builtins/comparesf2.c

__lesf2(fp_t a, fp_t b) {
     // sign-magnitude representation, then this flip is incorrect).
     else {
         if (aInt > bInt) return LE_LESS;
         else if (aInt == bInt) return LE_EQUAL;
         else return LE_GREATER;
     }
 }
 
+// Alias for libgcc compatibility
+FNALIAS(__cmpsf2, __lesf2);
+
 enum GE_RESULT {
     GE_LESS      = -1,
     GE_EQUAL     =  0,
     GE_GREATER   =  1,
     GE_UNORDERED = -1   // Note: different from LE_UNORDERED
 };
 
 COMPILER_RT_ABI enum GE_RESULT

compiler-rt/trunk/lib/builtins/comparetf2.c

else {
         // complement integer representation; if integers are represented in a
         // sign-magnitude representation, then this flip is incorrect).
         if (aInt > bInt) return LE_LESS;
         else if (aInt == bInt) return LE_EQUAL;
         else return LE_GREATER;
     }
 }
 
+// Alias for libgcc compatibility
+FNALIAS(__cmptf2, __letf2);
+
 enum GE_RESULT {
     GE_LESS      = -1,
     GE_EQUAL     =  0,
     GE_GREATER   =  1,
     GE_UNORDERED = -1   // Note: different from LE_UNORDERED
 };
 
 COMPILER_RT_ABI enum GE_RESULT __getf2(fp_t a, fp_t b) {

compiler-rt/trunk/lib/builtins/int_lib.h

 
 #ifndef INT_LIB_H
 #define INT_LIB_H
 
 /* Assumption: Signed integral is 2's complement. */
 /* Assumption: Right shift of signed negative is arithmetic shift. */
 /* Assumption: Endianness is little or big (not mixed). */
 
+#define FNALIAS(alias_name, original_name) \
+  void alias_name() __attribute__((alias(#original_name)))
+
 /* ABI macro definitions */
 
 #if __ARM_EABI__
 # define ARM_EABI_FNALIAS(aeabi_name, name)         \
   void __aeabi_##aeabi_name() __attribute__((alias("__" #name)));
 # define COMPILER_RT_ABI __attribute__((pcs("aapcs")))
 #else
 # define ARM_EABI_FNALIAS(aeabi_name, name)