This is an archive of the discontinued LLVM Phabricator instance.

[LLGS] Avoid misrepresenting log lines as inferior output
ClosedPublic

Authored by labath on Aug 17 2015, 7:51 AM.

Details

Summary

in case we are logging to stdout, any log lines from the forked child can be misconstrued to be
inferior output. To avoid this, we disable all logging immediately after forking.

I also fix the implementatoion of DisableAllLogChannels, which was a no-op before this commit.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 32298.Aug 17 2015, 7:51 AM
labath retitled this revision from to [LLGS] Avoid misrepresenting log lines as inferior output.
labath updated this object.
labath added reviewers: clayborg, ovyalov.
labath added subscribers: lldb-commits, dean.
clayborg accepted this revision.Aug 17 2015, 10:51 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Aug 17 2015, 10:51 AM
ovyalov accepted this revision.Aug 17 2015, 3:29 PM
ovyalov edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.