This is an archive of the discontinued LLVM Phabricator instance.

Convert all use of pthreads in test executables to std threads
ClosedPublic

Authored by zturner on Aug 14 2015, 3:21 PM.

Details

Summary

This eliminates portability issues among platforms that don't have a pthreads implementation.

There was one situation in TestTlsGlobals.py where it seems the intention is to compile the executable with C. In that case I left it alone, and we will need to eventually provide a windows-based implementation of that test. But for tests which don't explicitly require pure C for the test, I don't see a good reason not to use std threads across the board.

Diff Detail

Event Timeline

zturner updated this revision to Diff 32194.Aug 14 2015, 3:21 PM
zturner retitled this revision from to Convert all use of pthreads in test executables to std threads.
zturner updated this object.
zturner added reviewers: clayborg, jingham.
zturner added a subscriber: lldb-commits.
zturner updated this revision to Diff 32195.Aug 14 2015, 3:23 PM

Remove unicode byte-order-marks from python files

clayborg accepted this revision.Aug 14 2015, 4:08 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Aug 14 2015, 4:08 PM
zturner closed this revision.Oct 15 2015, 1:52 PM
test/functionalities/thread/thread_specific_break/TestThreadSpecificBreakpoint.py