Logically Dead Code

[chakshugrover]

Summary

Removed Logically Dead Code

3373	  const unsigned MaxEditDistance = 1;
3374	  unsigned BestEditDistance = MaxEditDistance + 1;

assigns BestEditDistance=2U

3382	  if (EditDistance > MaxEditDistance)
3383	    return;

As we take false branch after it, so EditDistance is atmost 1U after this check.

3384	  if (EditDistance == BestEditDistance)
3385	    BestMethod.push_back(Method);

As EditDistance is atmost 1U and BestEditDistance is 2U, So this condition can never be true and can be removed

3386	  else if (EditDistance < BestEditDistance) {

And this condition is always true so check can be removed.
So in fact BestEditDistance can essentially be completely removed from the code.

[chakshugrover]

Gentle ping!

lib/Sema/SemaDeclObjC.cpp

ObjCMethodDecl *Sema::LookupImplementedMethodInGlobalPool(Selector Sel) {
   return nullptr;
 }
 
 static void
 HelperSelectorsForTypoCorrection(
                       SmallVectorImpl<const ObjCMethodDecl *> &BestMethod,
                       StringRef Typo, const ObjCMethodDecl * Method) {
   const unsigned MaxEditDistance = 1;
-  unsigned BestEditDistance = MaxEditDistance + 1;
   std::string MethodName = Method->getSelector().getAsString();
   
   unsigned MinPossibleEditDistance = abs((int)MethodName.size() - (int)Typo.size());
   if (MinPossibleEditDistance > 0 &&
       Typo.size() / MinPossibleEditDistance < 1)
     return;
   unsigned EditDistance = Typo.edit_distance(MethodName, true, MaxEditDistance);
   if (EditDistance > MaxEditDistance)
     return;
-  if (EditDistance == BestEditDistance)
-    BestMethod.push_back(Method);
-  else if (EditDistance < BestEditDistance) {
-    BestMethod.clear();
-    BestMethod.push_back(Method);
-  }
-}
 
 static bool HelperIsMethodInObjCType(Sema &S, Selector Sel,
                                      QualType ObjectType) {
   if (ObjectType.isNull())
     return true;
   if (S.LookupMethodInObjectType(Sel, ObjectType, true/*Instance method*/))
     return true;
   return S.LookupMethodInObjectType(Sel, ObjectType, false/*Class method*/) !=