This is an archive of the discontinued LLVM Phabricator instance.

[UpdateTestChecks] Don't skip first line with --filter
ClosedPublic

Authored by sebastian-ne on Feb 14 2022, 3:09 AM.
Tokens
"Love" token, awarded by JOE1994.

Details

Summary

body_start was never used, resulting in the first filtered line to be
skipped.
Fixes the --filter option introduced in D117694.

Diff Detail

Event Timeline

sebastian-ne created this revision.Feb 14 2022, 3:09 AM
sebastian-ne requested review of this revision.Feb 14 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 3:09 AM

friendly ping for review

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2022, 5:52 AM
JOE1994 added a subscriber: JOE1994.Mar 2 2022, 5:52 AM
spatel accepted this revision.Mar 3 2022, 7:36 AM
spatel added a subscriber: spatel.

LGTM - I haven't used this option with the script, but the test diffs look right.

This revision is now accepted and ready to land.Mar 3 2022, 7:36 AM
This revision was landed with ongoing or failed builds.Mar 3 2022, 8:27 AM
This revision was automatically updated to reflect the committed changes.