Export snprintf to avoid linking error with liblldb on Windows.

[ovyalov]

LGTM

[zturner]

You need to use LIBLLDB_API instead of __declspec(export). Otherwise
someone linking against liblldb and trying to call this won't work
correctly. Check the annotation given to the classes in the SB headers for
the exact name of the macro.

[chaoren]

Sorry! I'll fix this as soon as I get home.

I have a question though, isn't this only a problem if whatever's linking
against lldb includes this header? This isn't in the API, so that shouldn't
happen. I also don't know if it's correct to label it LLDB_API when it's
not actually part of the API.

[zturner]

True that it only needs to be included if it's part of the api. Are we
sure it can't happen through a transitive include?

As long as the user of liblldb doesn't see the declaration it shouldn't be
a problem.

lldb/trunk/include/lldb/Host/windows/win32.h

 int chdir(const char* path);
 char* basename(char *path);
 char *dirname(char *path);
 
 int strcasecmp(const char* s1, const char* s2);
 int strncasecmp(const char* s1, const char* s2, size_t n);
 
 #if _MSC_VER < 1900
-int snprintf(char *buffer, size_t count, const char *format, ...);
+int __declspec(dllexport)
+snprintf(char *buffer, size_t count, const char *format, ...);
 #endif
 
 #define STDIN_FILENO  0
 #define STDOUT_FILENO 1
 #define STDERR_FILENO 2
 
 #define __PRETTY_FUNCTION__ __FUNCSIG__