Avoid making changes not relevant to this change. This seems like a fine change to do separately.
The type is obvious so you could just use auto *. Also, consider splitting this into another function to reduce indentation.
Initialisms are typically capitalized.
This could be written more concisely as: !LHSConst != !RHSConst. The xor is a little out of place considering you aren't doing anything with bits.
The description is not wrong, but I would've described it differently:
// Block-local map of equivalent values to their leader, does not propagate to any successors. Entries added mid-block are applied to the remaining instructions in the block. SmallMapVector<llvm::Value*, llvm::Constant*, 4> LocalLeaderMap;
Notably there's nothing *const-y* about it. We often replace X with Y when both are Instructions, or when Y is an Argument, or in this case when Y is a Constant. What's special about this is that it's block-local.
Extra spaces before semicolons
LHS and RHS. If you're worried about shadowing the existing LHS and RHS, I'd suggest ICmpLHS and ICmpRHS or ICmpOp0 and ICmpOp1.
The common idiom is to check which is Constant and then use std::swap.
However, we canonicalize constants to the RHS when possible (ie., not "sub" instructions). Any reason it would be de-canonicalized at this point?
Surely this fits on fewer lines?
I suspect this should have a quick exit for the common case where ReplaceWithConstMap is empty. Putting the test here might make sense, so that we don't even call it at -O0.
We surely don't want to iterate over the operands calling find on an empty map.
|1 ↗||(On Diff #31712)|
Please merge the two tests, using FileCheck for both of them. I think you can replace the grep with a CHECK: here.
So, this is essentially trying to start to get GVN to recognize that operations are made of operations on value numbers.
Except you are only handling the really special case where those value numbers are constant over the entire program (instead of also handling cases where the operations simplify, or have arithmetic niceties, etc. SimplifyInstruction will do some of this, but it won't notice some classes of things)
I'm generally biased against trying to bolt more into our current GVN, but hey, when you do stuff like this, it just makes New GVN a lot faster by comparison :)
Why only ICMP_EQ?
This isn't quite right :)
For example, i know your code doesn't quite work right with assume followed by certain types of switch statements (where there are multiple edges to the same successor).
See the code handling switch statements, that verifies there are not multiple edges to the same successor, and if there are not, *does not call propagateEquality* (old line 2259)
You are going to either need to unify or duplicate a lot of this kind of logic, depending on the terminator of the basic block the assume statement is in.
Not just that.
llvm.assume asserts whatever the condition is, is true.
PropagateEquality will propagate equalities like (A < B) == true as
well, by replacing all dominated instances of A>= B == false.
So you should be able to "propagate" basically all the ICMP variants.
Please add a string to this: assert(expression && "Failure message"); See http://llvm.org/docs/CodingStandards.html#assert-liberally
Wrong context. Use the same context from any Type or Value you have.
Let me explain what llvm contexts are for. They're intended to keep different threads separate, and keep them from accessing each others data, since llvm does not have internal locking. So the context owns the types and constant, and if two threads try to create "i1 true" at the same time then they'll race on updating the map. (Also, it's a verifier failure to have two Type*'s form two contexts involved in the same Module. By default everyone just uses the global context, but there may be a library user that does not.)
Reflow this comment.
Reflow this comment.
|6–22 ↗||(On Diff #32252)|
Please interleave the check statements with the function being tested. This helps show which calls should I expect to become direct calls to foo and bar.
|15 ↗||(On Diff #32252)|
I think this comment could be made more clear. Why can't equality propagation be done for every successor? What does propagateEquality check? Something like:
"This property is only true in dominated successors, propagateEquality will check dominance for us."
|28 ↗||(On Diff #32373)|
Is this a call to _ZN1A3fooEv or _Z1A3barEv? Put the CHECK line next to this line (usually right after).