This is an archive of the discontinued LLVM Phabricator instance.

Initialize base class by move constructor instead of copy constructor
ClosedPublic

Authored by aaron.ballman on Aug 10 2015, 9:57 AM.

Details

Summary

The move constructor for FullDependence is initializing the base class via a copy constructor instead of a move constructor. This patch adds a default move constructor to the base class, and makes use of it from the derived class instead of half-moving/half-copying the object.

I'm not certain if this was accidentally forgotten as part of r243791, or was purposeful.

~Aaron

Diff Detail

Event Timeline

aaron.ballman retitled this revision from to Initialize base class by move constructor instead of copy constructor.
aaron.ballman updated this object.
aaron.ballman added a reviewer: dblaikie.
aaron.ballman added a subscriber: llvm-commits.
aaron.ballman accepted this revision.Aug 12 2015, 2:12 PM
aaron.ballman added a reviewer: aaron.ballman.

This was commit in r244812.

This revision is now accepted and ready to land.Aug 12 2015, 2:12 PM
aaron.ballman closed this revision.Aug 12 2015, 2:12 PM