This is an archive of the discontinued LLVM Phabricator instance.

Differential D11903

[UBSan] Enable 'help' option output, report unrecognized flags
ClosedPublic

Authored by • ryabkova.svetlana on Aug 10 2015, 6:36 AM.

Details

Reviewers
glider
samsonov
Commits
rGff1ca4af4b74: [UBSan] Enable 'help' option output, report unrecognized flags
rCRT244946: [UBSan] Enable 'help' option output, report unrecognized flags
rL244946: [UBSan] Enable 'help' option output, report unrecognized flags
Summary

Let UBSan output flag description if 'help' options is provided.
Report unrecognized flags if verbosity mode is turned on.

Diff Detail

Repository
rL LLVM

Event Timeline

• ryabkova.svetlana updated this revision to Diff 31661.Aug 10 2015, 6:36 AM
• ryabkova.svetlana retitled this revision from to [UBSan] Enable 'help' option output, report unrecognized flags.
• ryabkova.svetlana updated this object.
• ryabkova.svetlana added a reviewer: samsonov.
• ryabkova.svetlana added a subscriber: llvm-commits.
• ryabkova.svetlana added a reviewer: glider.Aug 12 2015, 8:51 AM
• ryabkova.svetlana added a subscriber: ygribov.
samsonov accepted this revision.Aug 12 2015, 4:42 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 12 2015, 4:42 PM
glider accepted this revision.Aug 13 2015, 6:08 AM
glider edited edge metadata.

LGTM

• ryabkova.svetlana added a comment.Aug 13 2015, 9:16 AM
In D11903#223355, @samsonov wrote:

LGTM

Alexey, could you commit this patch?

Closed by commit rL244946: [UBSan] Enable 'help' option output, report unrecognized flags (authored by samsonov). · Explain WhyAug 13 2015, 1:34 PM
This revision was automatically updated to reflect the committed changes.
• ryabkova.svetlana added a comment.Aug 14 2015, 12:56 AM

Thanks a lot!

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
ubsan/
3 lines

Diff 32090

compiler-rt/trunk/lib/ubsan/ubsan_flags.cc

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Linesvoid InitializeFlags() {
RegisterCommonFlags(&parser); RegisterCommonFlags(&parser);
RegisterUbsanFlags(&parser, f); RegisterUbsanFlags(&parser, f);
// Override from user-specified string. // Override from user-specified string.
parser.ParseString(MaybeCallUbsanDefaultOptions()); parser.ParseString(MaybeCallUbsanDefaultOptions());
// Override from environment variable. // Override from environment variable.
parser.ParseString(GetEnv("UBSAN_OPTIONS")); parser.ParseString(GetEnv("UBSAN_OPTIONS"));
SetVerbosity(common_flags()->verbosity); SetVerbosity(common_flags()->verbosity);
if (Verbosity()) ReportUnrecognizedFlags();
if (common_flags()->help) parser.PrintFlagDescriptions();
} }
} // namespace __ubsan } // namespace __ubsan
extern "C" { extern "C" {
#if !SANITIZER_SUPPORTS_WEAK_HOOKS #if !SANITIZER_SUPPORTS_WEAK_HOOKS
SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE
Show All 15 Lines