This is an archive of the discontinued LLVM Phabricator instance.

[PHITransAddr] Don't assume that instruction operands are translatable
ClosedPublic

Authored by majnemer on Aug 8 2015, 5:26 PM.

Details

Summary

We can only PHI translate instructions. In our attempt to PHI translate
a bitcast, we attempt to translate its operand; however, the operand
might be an argument or a global instead of an instruction. Benignly
bail out when this happens.

This fixes PR24397.

Diff Detail

Event Timeline

majnemer updated this revision to Diff 31604.Aug 8 2015, 5:26 PM
majnemer retitled this revision from to [PHITransAddr] Don't assume that instruction operands are translatable.
majnemer updated this object.
majnemer added a subscriber: llvm-commits.
mzolotukhin accepted this revision.Aug 8 2015, 10:20 PM
mzolotukhin edited edge metadata.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 8 2015, 10:20 PM
This revision was automatically updated to reflect the committed changes.