This is an archive of the discontinued LLVM Phabricator instance.

Fix REPE, REPZ, REPNZ for intel syntax
ClosedPublic

Authored by myatsina on Aug 6 2015, 1:27 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

myatsina updated this revision to Diff 31355.Aug 6 2015, 1:27 AM
myatsina retitled this revision from to Fix REPE, REPZ, REPNZ for intel syntax.
myatsina updated this object.
myatsina added a reviewer: mcrosier.
myatsina set the repository for this revision to rL LLVM.
myatsina added a subscriber: llvm-commits.
myatsina updated this revision to Diff 31436.Aug 6 2015, 3:40 AM

removed "rep" case from the test

mcrosier edited edge metadata.Aug 6 2015, 6:04 AM

And by fix you mean we should be applying the mnemonic aliases for both the Intel and
AT&T dialect unconditionally?

test/MC/X86/intel-syntax.s
7

Please put spaces between "//" and the "CHECK".

myatsina updated this revision to Diff 31614.Aug 9 2015, 1:40 AM
myatsina edited edge metadata.

Added space between '//' and 'CHECK:'

REPE, REPZ, REPNZ, REPNE should have mnemonics for Intel syntax as well.
Currently using these instructions causes compilation errors for Intel syntax.

mcrosier accepted this revision.Aug 10 2015, 6:33 AM
mcrosier edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 10 2015, 6:33 AM
This revision was automatically updated to reflect the committed changes.