This is an archive of the discontinued LLVM Phabricator instance.

Revert "[libc++] [test] UNSUPPORTED my new uniform_int_distribution test on MinGW."
AbandonedPublic

Authored by Quuxplusone on Jan 20 2022, 11:22 AM.

Details

Reviewers
mstorsjo
Group Reviewers
Restricted Project
Summary

In 5820322cb1cb9df5f05a49ed9d86984c0ac7d28d I marked this test UNSUPPORTED on MinGW to fix a CI failure, but why it fails on MinGW is still a mystery to me. Hoping @mstorsjo or somebody can help figure it out.
In that commit, I had written:

After 9fe67486cc, this test fails on MinGW for some reason.
https://buildkite.com/llvm-project/libcxx-ci/builds/7922#9e267294-441d-4b79-8a19-30fdb5599c1f
All it says in the build output is

note: command had no output on stdout or stderr
error: command failed with exit status: 4294967295

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.Jan 20 2022, 11:22 AM
Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 20 2022, 11:22 AM

I had a look, and it seems to run correctly when built with a recent Clang 14 snapshot. But with Clang 13.0.0 as in the CI, it crashes.

The crash backtrace looks like this:

#0  0x00007ff6a3c107f7 in __floattidf ()
#1  0x00007ff6a3c0c42a in double std::__1::accumulate<std::__1::__wrap_iter<__int128*>, double>(std::__1::__wrap_iter<__int128*>, std::__1::__wrap_iter<__int128*>, double) ()
#2  0x00007ff6a3bf3a2f in void test_statistics<__int128, std::__1::linear_congruential_engine<unsigned int, 16807u, 0u, 2147483647u> >(__int128, __int128) ()
#3  0x00007ff6a3bf3303 in void test_statistics<__int128, std::__1::linear_congruential_engine<unsigned int, 16807u, 0u, 2147483647u> >() ()
#4  0x00007ff6a3bf1526 in main ()

Therefore, I think the fix for this bug, that already is present in Clang 14, probably is this one: https://reviews.llvm.org/D110413.

So I guess if we wanted to, we could change this into XFAIL: target={{.+}}-windows-gnu && clang-13, to have the test automatically taken into use when we upgrade the CI.

Quuxplusone abandoned this revision.Jan 26 2022, 8:21 AM

Superseded by D118235 — thanks @mstorsjo!