"Claim" the arguments belonging to 'clang_ignored_gcc_optimization_f_Group'

[dougk]

Summary

This seems preferable to printing two warnings per use of an unsupported option- one about not supporting it, and one about the compiler invocation not using it.

It also makes the '-Wno-' flag do what you mean with respect to those ignored options. Given that clang_ignored_f_Group are silently ignored, it seems obvious that the W flag is intended to suppress warnings about things that would otherwise print something, not arguments that are totally effectless.

Though why there are two groups at all is strange - the gcc group was added in r212805 when the clang_ignored_f_group already existed. I suppose it would have been incompatible to make the clang_ignored_f_group start to issue warnings.

[mcrosier]

LGTM.

cfe/trunk/lib/Driver/Tools.cpp

if (A->getOption().matches(options::OPT_O4)) {
       A->render(Args, CmdArgs);
     }
   }
 
   // Warn about ignored options to clang.
   for (const Arg *A :
        Args.filtered(options::OPT_clang_ignored_gcc_optimization_f_Group)) {
     D.Diag(diag::warn_ignored_gcc_optimization) << A->getAsString(Args);
+    A->claim();
   }
 
   claimNoWarnArgs(Args);
 
   Args.AddAllArgs(CmdArgs, options::OPT_R_Group);
   Args.AddAllArgs(CmdArgs, options::OPT_W_Group);
   if (Args.hasFlag(options::OPT_pedantic, options::OPT_no_pedantic, false))
     CmdArgs.push_back("-pedantic");

cfe/trunk/test/Driver/clang_f_opts.c

 // RUN: %clang -### -finline-limit -Wno-invalid-command-line-argument                   \
 // RUN:     %s 2>&1 | FileCheck --check-prefix=CHECK-NO-WARNING2 %s
 // RUN: %clang -### -finline-limit \
 // RUN:     -Winvalid-command-line-argument -Wno-ignored-optimization-argument          \
 // RUN:     %s 2>&1 | FileCheck --check-prefix=CHECK-NO-WARNING2 %s
 // CHECK-NO-WARNING1-NOT: optimization flag '-finline-limit=1000' is not supported
 // CHECK-NO-WARNING2-NOT: optimization flag '-finline-limit' is not supported
 
+// Test that an ignored optimization argument only prints 1 warning,
+// not both a warning about not claiming the arg, *and* about not supporting
+// the arg; and that adding -Wno-ignored-optimization silences the warning.
+//
+// RUN: %clang -### -fprofile-correction %s 2>&1 \
+// RUN:   | FileCheck --check-prefix=CHECK-NO-WARNING3 %s
+// CHECK-NO-WARNING3: optimization flag '-fprofile-correction' is not supported
+// CHECK-NO-WARNING3-NOT: argument unused
+// RUN: %clang -### -fprofile-correction -Wno-ignored-optimization-argument %s 2>&1 \
+// RUN:   | FileCheck --check-prefix=CHECK-NO-WARNING4 %s
+// CHECK-NO-WARNING4-NOT: not supported
+// CHECK-NO-WARNING4-NOT: argument unused
+
 // RUN: %clang -### -S -fsigned-char %s 2>&1 | FileCheck -check-prefix=CHAR-SIGN1 %s
 // CHAR-SIGN1-NOT: -fno-signed-char
 
 // RUN: %clang -### -S -funsigned-char %s 2>&1 | FileCheck -check-prefix=CHAR-SIGN2 %s
 // CHAR-SIGN2: -fno-signed-char
 
 // RUN: %clang -### -S -fno-signed-char %s 2>&1 | FileCheck -check-prefix=CHAR-SIGN3 %s
 // CHAR-SIGN3: -fno-signed-char