Escape variable creation error messages.

[paulmaybee]

Summary

Expression evaluation error messages may have embedded new lines and tabs. These should be escaped in the result string.

[ki.stfu]

tools/lldb-mi/MICmdCmdVar.cpp

258

I believe we should also escape quotes, isn't it?

Use:

const CMICmnMIValueConst miValueConst(strErrMsg.Escape(true /* vbEscapeQuotes */));

[paulmaybee]

Escape quotes too.

[paulmaybee]

Can you please check it in? Thanks.

[abidh]

Committed in 243741.

test/tools/lldb-mi/variable/TestMiVar.py

 
         # Print non-existant variable
         self.runCmd("-var-create var1 * undef")
-        self.expect("\^error,msg=\"error: error: use of undeclared identifier \'undef\'\s+error: 1 errors parsing expression\"")
+        self.expect("\^error,msg=\"error: error: use of undeclared identifier \'undef\'\\\\nerror: 1 errors parsing expression\\\\n\"")
         self.runCmd("-data-evaluate-expression undef")
         self.expect("\^error,msg=\"Could not evaluate expression\"")
 

tools/lldb-mi/MICmdCmdVar.cpp

     CMIUtilString strErrMsg(m_strValue);
     if (m_strValue.empty())
         strErrMsg = CMIUtilString::Format(MIRSRC(IDS_CMD_ERR_VARIABLE_CREATION_FAILED), m_strExpression.c_str());
-    const CMICmnMIValueConst miValueConst(strErrMsg);
+    const CMICmnMIValueConst miValueConst(strErrMsg.Escape(true /* vbEscapeQuotes */));
     CMICmnMIValueResult miValueResult("msg", miValueConst);
     const CMICmnMIResultRecord miRecordResult(m_cmdData.strMiCmdToken, CMICmnMIResultRecord::eResultClass_Error, miValueResult);
     m_miResultRecord = miRecordResult;