- User Since
- Mar 10 2015, 10:23 AM (346 w, 1 d)
Jul 12 2016
Jun 28 2016
Apr 8 2016
closed with http://reviews.llvm.org/rL265858
Dec 7 2015
@zturner I successfully submitted my test commit from an svn working copy. My former workflow was to use the read only git mirror, generate a diff, and submit it through this tool. Is there a better way to use differential so that I can submit directly via an approved code review?
Dec 4 2015
@zturner I have been granted commit after approval from Chris. How do I commit from here?
I requested it, thanks for the heads up!
Can you check this in for me?
Dec 3 2015
Thanks! Can you or somebody with commit access check this in for me?
Dec 2 2015
Jul 29 2015
May 12 2015
May 11 2015
Can somebody please check this in?
May 8 2015
Merge the new disassembly test into the original
May 7 2015
Added test for escaped characters in disassembly comments
May 6 2015
I do need the --waitfor option. I am now skipping these tests on Linux.
May 5 2015
I removed the requirement for -file-exec-and-symbols to be called before -target-attach. I was able to fix the tests for -target-attach <pid> and -target-attach -n <name>. I was able to get -target-attach -n <name> --waitfor to work in practice, but not through the python test without first issuing a -file-exec-and-symbols. Any help would be appreciated.
May 4 2015
Respond to Ilia K's feedback.
Apr 28 2015
Could somebody please check this in for me?
Apr 27 2015
Apr 8 2015
Thank you for the information.
That would be perfect, thanks.
Do I need more sign off to get this checked in?
Apr 7 2015
What do you mean? It is printed:
Apr 6 2015
Can somebody check this in for me now that it has been approved?
Apr 3 2015
Apr 2 2015
All lld-mi tests passing.
Mar 19 2015
removed extraneous fix. Can somebody please check this in on my behalf?
I fixed the comments based on feedback from Ilia K. Can somebody please check this in on my behalf?
Mar 18 2015
I am now using the PRIx64 macro in all locations. I checked and made sure that every type being used is either an MIUint64 or and lldb::addr_t, both of with are uint64s. I also noticed that IDS_CMD_ERR_LLDB_ERR_READ_MEM_BYTES was being initialized twice, and switched the second initialization to the correct IDS_CMD_ERR_LLDB_ERR_NOT_WRITE_WHOLEBLK
Mar 12 2015
Fixed all the places I could find.
I am still new to this and I cannot commit directly. Should I submit a new patch with these minor changes, or will somebody with commit access make them and submit on my behalf?
Added comment on FileExecAndSymbols to see MIExtensions.txt. Fixed capitalization in comments.
Mar 11 2015
Updated based on code review feedback. We confirmed that the interpret-exec command does not suit our needs, and have documented the flags that we have added to file-exec-and-symbols.
These are the files that have the string '%08' in them, should I fix all of them up as part of this patch?