Page MenuHomePhabricator

ChuckR (Chuck Ries)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2015, 10:23 AM (346 w, 1 d)

Recent Activity

Jul 12 2016

ChuckR added a reviewer for D21757: Fix lldb-mi disable/enable breakpoints commands: ki.stfu.
Jul 12 2016, 5:04 PM
ChuckR updated subscribers of D21757: Fix lldb-mi disable/enable breakpoints commands.

@abidh @ki.stfu Do you have any feedback? We would like to check this in and I want to get more sign off then just me.

Jul 12 2016, 5:04 PM

Jun 28 2016

ChuckR accepted D21757: Fix lldb-mi disable/enable breakpoints commands.
Jun 28 2016, 3:56 PM

Apr 8 2016

ChuckR closed D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id.

closed with http://reviews.llvm.org/rL265858

Apr 8 2016, 3:25 PM
ChuckR committed rL265858: -thread-info in lldbmi does not conform to protocol. Should end with current….
-thread-info in lldbmi does not conform to protocol. Should end with current…
Apr 8 2016, 3:23 PM

Dec 7 2015

ChuckR committed rL254941: Allow variable names to be quoted with -var-list-children.
Allow variable names to be quoted with -var-list-children
Dec 7 2015, 12:47 PM
ChuckR closed D15168: Allow variable names to be quoted with -var-list-children by committing rL254941: Allow variable names to be quoted with -var-list-children.
Dec 7 2015, 12:47 PM
ChuckR added a comment to D15168: Allow variable names to be quoted with -var-list-children.

Ok, thanks.

Dec 7 2015, 11:27 AM
ChuckR added a comment to D15168: Allow variable names to be quoted with -var-list-children.

@zturner I successfully submitted my test commit from an svn working copy. My former workflow was to use the read only git mirror, generate a diff, and submit it through this tool. Is there a better way to use differential so that I can submit directly via an approved code review?

Dec 7 2015, 11:16 AM
ChuckR committed rL254924: test commit..
test commit.
Dec 7 2015, 11:11 AM

Dec 4 2015

ChuckR added a comment to D15168: Allow variable names to be quoted with -var-list-children.

@zturner I have been granted commit after approval from Chris. How do I commit from here?

Dec 4 2015, 5:15 PM
ChuckR added a comment to D15168: Allow variable names to be quoted with -var-list-children.

I requested it, thanks for the heads up!

Dec 4 2015, 4:33 PM
ChuckR added a reviewer for D15168: Allow variable names to be quoted with -var-list-children: zturner.

Can you check this in for me?

Dec 4 2015, 2:56 PM

Dec 3 2015

ChuckR added a comment to D15168: Allow variable names to be quoted with -var-list-children.

Thanks! Can you or somebody with commit access check this in for me?

Dec 3 2015, 12:49 PM

Dec 2 2015

ChuckR retitled D15168: Allow variable names to be quoted with -var-list-children from to Allow variable names to be quoted with -var-list-children.
Dec 2 2015, 4:24 PM

Jul 29 2015

ChuckR abandoned D9716: Add 'size' field to module load event..
Jul 29 2015, 12:05 PM

May 12 2015

ChuckR retitled D9716: Add 'size' field to module load event. from to Add 'size' field to module load event..
May 12 2015, 1:51 PM

May 11 2015

ChuckR added a comment to D9544: Escape strings in disassembly comments..

Thank you.

May 11 2015, 11:56 PM
ChuckR added a comment to D9691: Show error message from failed evaluation when doing -var-create.

Thank you.

May 11 2015, 11:56 PM
ChuckR retitled D9691: Show error message from failed evaluation when doing -var-create from to Show error message from failed evaluation when doing -var-create.
May 11 2015, 5:27 PM
ChuckR added a comment to D9544: Escape strings in disassembly comments..

Can somebody please check this in?

May 11 2015, 10:50 AM

May 8 2015

ChuckR updated the diff for D9544: Escape strings in disassembly comments..

Merge the new disassembly test into the original

May 8 2015, 11:18 AM

May 7 2015

ChuckR updated the diff for D9544: Escape strings in disassembly comments..

Added test for escaped characters in disassembly comments

May 7 2015, 2:45 PM

May 6 2015

ChuckR retitled D9544: Escape strings in disassembly comments. from to Escape strings in disassembly comments..
May 6 2015, 5:38 PM
ChuckR updated the diff for D9484: Implement -target-attach and -target-detach.

I do need the --waitfor option. I am now skipping these tests on Linux.

May 6 2015, 9:32 AM

May 5 2015

ChuckR updated the diff for D9484: Implement -target-attach and -target-detach.

I removed the requirement for -file-exec-and-symbols to be called before -target-attach. I was able to fix the tests for -target-attach <pid> and -target-attach -n <name>. I was able to get -target-attach -n <name> --waitfor to work in practice, but not through the python test without first issuing a -file-exec-and-symbols. Any help would be appreciated.

May 5 2015, 1:44 PM

May 4 2015

ChuckR updated the diff for D9484: Implement -target-attach and -target-detach.

Respond to Ilia K's feedback.

May 4 2015, 2:51 PM
ChuckR retitled D9484: Implement -target-attach and -target-detach from to Implement -target-attach and -target-detach.
May 4 2015, 12:28 PM

Apr 28 2015

ChuckR added a reviewer for D9317: Implement -stack-list-variables: ki.stfu.

Could somebody please check this in for me?

Apr 28 2015, 11:11 AM

Apr 27 2015

ChuckR retitled D9317: Implement -stack-list-variables from to Implement -stack-list-variables.
Apr 27 2015, 6:34 PM

Apr 8 2015

ChuckR added a comment to D8847: Generate an event when a pending breakpoint binds.

Thank you for the information.

Apr 8 2015, 4:34 PM
ChuckR added a comment to D8847: Generate an event when a pending breakpoint binds.

That would be perfect, thanks.

Apr 8 2015, 2:56 PM
ChuckR added a comment to D8847: Generate an event when a pending breakpoint binds.

Do I need more sign off to get this checked in?

Apr 8 2015, 2:32 PM

Apr 7 2015

ChuckR added a comment to D8847: Generate an event when a pending breakpoint binds.

What do you mean? It is printed:

Apr 7 2015, 10:12 AM

Apr 6 2015

ChuckR updated the test plan for D8847: Generate an event when a pending breakpoint binds.
Apr 6 2015, 3:27 PM
ChuckR updated the test plan for D8847: Generate an event when a pending breakpoint binds.
Apr 6 2015, 3:26 PM
ChuckR retitled D8847: Generate an event when a pending breakpoint binds from to Generate an event when a pending breakpoint binds.
Apr 6 2015, 3:24 PM
ChuckR added a comment to D8430: implement gdb-set output-radix.

Can somebody check this in for me now that it has been approved?

Apr 6 2015, 3:03 PM

Apr 3 2015

ChuckR updated the diff for D8430: implement gdb-set output-radix.

moved test

Apr 3 2015, 12:25 PM

Apr 2 2015

ChuckR added a comment to D8430: implement gdb-set output-radix.

All lld-mi tests passing.

Apr 2 2015, 6:37 PM
ChuckR updated the diff for D8430: implement gdb-set output-radix.

added test

Apr 2 2015, 6:36 PM

Mar 19 2015

ChuckR added a comment to D8430: implement gdb-set output-radix.

I agree with @abidh, that we should add tests for this. Could you do it?

Mar 19 2015, 10:35 AM
ChuckR updated the diff for D8430: implement gdb-set output-radix.

removed extraneous fix. Can somebody please check this in on my behalf?

Mar 19 2015, 10:26 AM
ChuckR updated the diff for D8238: expose 64 bit addresses through MI.

I fixed the comments based on feedback from Ilia K. Can somebody please check this in on my behalf?

Mar 19 2015, 10:15 AM

Mar 18 2015

ChuckR retitled D8430: implement gdb-set output-radix from to implement gdb-set output-radix.
Mar 18 2015, 5:21 PM
ChuckR updated the diff for D8238: expose 64 bit addresses through MI.

I am now using the PRIx64 macro in all locations. I checked and made sure that every type being used is either an MIUint64 or and lldb::addr_t, both of with are uint64s. I also noticed that IDS_CMD_ERR_LLDB_ERR_READ_MEM_BYTES was being initialized twice, and switched the second initialization to the correct IDS_CMD_ERR_LLDB_ERR_NOT_WRITE_WHOLEBLK

Mar 18 2015, 5:02 PM

Mar 12 2015

ChuckR updated the diff for D8238: expose 64 bit addresses through MI.

Fixed all the places I could find.

Mar 12 2015, 4:25 PM
ChuckR added a comment to D8210: Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS.
In D8210#140012, @abidh wrote:

I am still new to this and I cannot commit directly. Should I submit a new patch with these minor changes, or will somebody with commit access make them and submit on my behalf?

I will commit it for you after making those few changes.

Mar 12 2015, 11:25 AM
ChuckR added a comment to D8210: Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS.

I am still new to this and I cannot commit directly. Should I submit a new patch with these minor changes, or will somebody with commit access make them and submit on my behalf?

Mar 12 2015, 11:05 AM
ChuckR updated the diff for D8210: Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS.

Added comment on FileExecAndSymbols to see MIExtensions.txt. Fixed capitalization in comments.

Mar 12 2015, 10:22 AM

Mar 11 2015

ChuckR updated the diff for D8210: Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS.

Updated based on code review feedback. We confirmed that the interpret-exec command does not suit our needs, and have documented the flags that we have added to file-exec-and-symbols.

Mar 11 2015, 3:45 PM
ChuckR added a comment to D8238: expose 64 bit addresses through MI.

These are the files that have the string '%08' in them, should I fix all of them up as part of this patch?

Mar 11 2015, 10:40 AM
ChuckR added a comment to D8210: Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS.
In D8210#138716, @abidh wrote:
In D8210#138690, @abidh wrote:

I personally don't like using "-interpreter-exec" when there are proper MI commands available to do the job. But if start adding option/commands in lldb-mi for every options available in lldb proper then it will also get a little messy. Would it work for you to use "-interpreter-exec" as Ilia suggested above?

I don't insist on it if these options are well-known. As I said I don't see them in description of -file-exec-and-symbols command.

These options are not standard MI options. ChuckR is probably trying to add in lldb-mi what he see in "Target Create" command in lldb.

Then I dislike this patch. I'm not sure that we should add custom options. Is there another way to do it?

Mar 11 2015, 10:34 AM

Mar 10 2015

ChuckR retitled D8238: expose 64 bit addresses through MI from to expose 64 bit breakpoint addresses through MI.
Mar 10 2015, 4:47 PM
ChuckR retitled D8210: Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS from to Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS.
Mar 10 2015, 10:26 AM